Skip to content

Add ADO Server integration support #4478

@justinrobots

Description

@justinrobots

Verification steps

  • branch PR
    Image
    Image

    • If branch has closed PRs only, it shows one of them (most recent)
  • commit PR

    • also check that it does not break commit PRs for Azure Cloud
      Image
  • links work

    • commit link in the pop-up
      Image
    • open repository on remote
    • open branch on remote
    • open commit on remote
    • open commit file on remote
    • open PR on remote
    • open comparison on remote
  • autolinks in commit pop-up
    Image

    • PRs (template: PR <num>)
    • Issues (template: #<num>)
    • check that links of Issues and PRs work in pop-ups (both: under "#" and under their visible titles)
    • check that autolinks of other integration types are not borken
  • Launchpad

    • you see open PRs categorized
    • pin/unpin, snooze/unsnooze work and persist after reloading the window
    • a PR URL goes go to the right place on remote
    • switch to Branch works
    • open in Worktree works
    • "merge" works
  • Issues

    • You can associate an issue with the current branch on Home View
    • You can associate another issue with a branch on Branches View
      Image
    • Associated issues are displayed on Home View
      Image
    • Issue links work: open the right pages on remote
    • "Start Work" flow works
  • Rest of Home

    • Branch PR is shown on Home
    • If branch has closed PRs only, it shows one of them (most recent), same as on Branches View.
  • Compare links work ("Open comparison on remote")

  • check that all above still works for Azure Cloud

  • Check for possible breaking changes of the Library update. We've updated the library from 0.28.5 to 0.29.6, so we want to test the affected areas:

    • Bitbucket Server: there was an update in providerUtils/bitbucketServer.ts/normalizePermissions(). Probably, refactoring. It was an update of showing user avatars.
      • New method getRepoPermissionsForUsername and getAccountsForProject have been added. We might want to review our code to replace some pieces of our custom implementation with the library calls.
    • Azure DevOps Cloud: Server appeared so the logic of defining the base URL has been changed. Also retrieval user's organizations and collections might be affected.
    • GitLab: few changes related to avatars

Metadata

Metadata

Assignees

Labels

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions