-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Closed
Description
Description
Two bugs with cancellation in composer:
- Cancelling auto-compose shows an empty auto-compose summary. It should not show if the operation didn't complete.
- Cancelling commit message generation results in the composer showing an error rather than properly cancelling.
Repro steps:
- Open commit composer
- Try to generate commit message with no provider selected and github copilot disabled as an extension (so no vscode ai provider available) and not logged into GK (so no GK provider available as fallback)
- Cancel or escape at any point in the flow (choosing a provider, choosing a model, sign in prompt for GK provider)
- Expect for composer to treat it as a cancellation. See an error instead.
To verify the fix:
- Start an auto-compose without an AI provider selected, and cancel at the provider selection. No summary should show.
- Follow the repro steps above for commit message generation. When cancelling, no error should show.
- AI provider selection in other places should work as before
- AI commit message generation in other places as well as a few other AI ops should be spot-checked to make sure they still work as before
GitLens Version
17.5.0
VS Code Version
No response
Git Version
No response
Logs, Screenshots, Screen Captures, etc
No response
Metadata
Metadata
Assignees
Labels
verified ✔VerifiedVerified