Skip to content

Adds 'realpath' option to resolve symbolic links paths (#1328) #4754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 25, 2025
Merged

Adds 'realpath' option to resolve symbolic links paths (#1328) #4754

merged 5 commits into from
Nov 25, 2025
+39 −1

Conversation

@sergeibbb
Copy link
Member

@sergeibbb sergeibbb commented Nov 18, 2025 •
edited
Loading

Description

Solves #1328:

  • Adds 'realpath' option to resolve symbolic links when determining file paths for Git operations

This PR is based on user's suggestion #4743

Additionally to the suggested changes I've:

  • moved the new setting to "Advanced" section
  • moved realpath dependency to platform wrappers, by providing a blank wrapper for Web
  • replaced the realpathSync with its asynchronous version

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation (including CHANGELOG.md and README.md)
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

sergeibbb pushed a commit that referenced this pull request Nov 18, 2025
@Forest-Lover @sergeibbb
Adds 'realpath' option to resolve symbolic links when determining fil…
42e4a3f 
…e paths for Git operations

(#1328, #4754, #4743)
sergeibbb added a commit that referenced this pull request Nov 18, 2025
@sergeibbb
Moves realpath setting to advanced config section
ebd35aa 
(#1328, #4754)
@sergeibbb sergeibbb force-pushed the feature/1328-realpath branch from f502126 to d00f405 Compare November 18, 2025 14:27
sergeibbb added a commit that referenced this pull request Nov 18, 2025
@sergeibbb
Abstracts realpath handling for browser and Node environments
bf8dcd3 
(#1328, #4754)

Introduces environment-specific implementations for resolving real file
system paths, enabling the codebase to handle symlink resolution in
Node.js while providing a placeholder for browsers.
sergeibbb added a commit that referenced this pull request Nov 18, 2025
@sergeibbb
Mentions new "realpath" feature in CHANGELOG
d00f405 
(#1328, #4754)
@sergeibbb sergeibbb linked an issue Nov 19, 2025 that may be closed by this pull request
GitLens does not handle Windows junctions #1328
Closed
sergeibbb pushed a commit that referenced this pull request Nov 24, 2025
@Forest-Lover @sergeibbb
Adds 'realpath' option to resolve symbolic links when determining fil…
5f298e2 
…e paths for Git operations

(#1328, #4754, #4743)
sergeibbb added a commit that referenced this pull request Nov 24, 2025
@sergeibbb
Moves realpath setting to advanced config section
35e2c71 
(#1328, #4754)
@sergeibbb sergeibbb force-pushed the feature/1328-realpath branch from d00f405 to 968819c Compare November 24, 2025 13:12
sergeibbb added a commit that referenced this pull request Nov 24, 2025
@sergeibbb
Abstracts realpath handling for browser and Node environments
82e3c59 
(#1328, #4754)

Introduces environment-specific implementations for resolving real file
system paths, enabling the codebase to handle symlink resolution in
Node.js while providing a placeholder for browsers.
sergeibbb added a commit that referenced this pull request Nov 24, 2025
@sergeibbb
Mentions new "realpath" feature in CHANGELOG
968819c 
(#1328, #4754)
@sergeibbb
Copy link
Member Author

sergeibbb commented Nov 24, 2025

  • I've tested with simple symlinks on MacOS
  • also tested with git submodules

eamodio
eamodio reviewed Nov 24, 2025
View reviewed changes
Copy link
Member

@eamodio eamodio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a new commit with my code-review changes -- please take a look.

I still think this is the wrong way to resolve this, but maybe it will fix things for some users

@sergeibbb sergeibbb assigned sergeibbb and unassigned eamodio Nov 24, 2025
Forest-Lover and others added 5 commits November 25, 2025 11:26
@Forest-Lover @sergeibbb
Adds 'realpath' option to resolve symbolic links when determining fil…
c9a3b71 
…e paths for Git operations

(#1328, #4754, #4743)
@sergeibbb
Moves realpath setting to advanced config section
e3f0e77 
(#1328, #4754)
@sergeibbb
Abstracts realpath handling for browser and Node environments
0fe205a 
(#1328, #4754)

Introduces environment-specific implementations for resolving real file
system paths, enabling the codebase to handle symlink resolution in
Node.js while providing a placeholder for browsers.
@eamodio @sergeibbb
Changes from code review
64ac4a2 
(#1328, #4754)
@eamodio @sergeibbb
Normalizes the equal check
20ee929 
(#1328, #4754)
@sergeibbb sergeibbb force-pushed the feature/1328-realpath branch from 3940ed7 to 20ee929 Compare November 25, 2025 10:30
@sergeibbb sergeibbb merged commit b9d3854 into main Nov 25, 2025
4 checks passed
sergeibbb pushed a commit that referenced this pull request Nov 25, 2025
@Forest-Lover @sergeibbb
Adds 'realpath' option to resolve symbolic links when determining fil…
11c6530 
…e paths for Git operations

(#1328, #4754, #4743)
sergeibbb added a commit that referenced this pull request Nov 25, 2025
@sergeibbb
Moves realpath setting to advanced config section
77b124a 
(#1328, #4754)
sergeibbb added a commit that referenced this pull request Nov 25, 2025
@sergeibbb
Abstracts realpath handling for browser and Node environments
6375500 
(#1328, #4754)

Introduces environment-specific implementations for resolving real file
system paths, enabling the codebase to handle symlink resolution in
Node.js while providing a placeholder for browsers.
sergeibbb pushed a commit that referenced this pull request Nov 25, 2025
@eamodio @sergeibbb
Changes from code review
7288513 
(#1328, #4754)
@sergeibbb sergeibbb deleted the feature/1328-realpath branch November 25, 2025 10:43
This was referenced Nov 25, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eamodio eamodio eamodio left review comments

@axosoft-ramint axosoft-ramint Awaiting requested review from axosoft-ramint

Assignees

@sergeibbb sergeibbb

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

GitLens does not handle Windows junctions

4 participants

@sergeibbb @eamodio @Forest-Lover