Skip to content

Conversation

@czosel
Copy link
Collaborator

@czosel czosel commented Jun 25, 2025

Based on #1157

I wasn't able to update webpack due to typescript errors, similar to #1139:

Run yarn build-types
yarn run v1.22.22
$ jsdoc -t node_modules/tsd-jsdoc/dist -r src -d . && prettier -w types.d.ts
types.d.ts 147ms
Done in 1.20s.
Error: node_modules/@types/eslint-scope/index.d.ts(7,5): error TS241[6](https://github.com/glayzzle/php-parser/actions/runs/15875004609/job/44760386700#step:5:7): Property 'scopes' in type 'ScopeManager' is not assignable to the same property in base type 'ScopeManager'.
  Type 'import("/home/runner/work/php-parser/php-parser/node_modules/@types/eslint-scope/index").Scope[]' is not assignable to type 'import("/home/runner/work/php-parser/php-parser/node_modules/eslint/lib/types/index").Scope.Scope[]'.

@czosel czosel force-pushed the update-deps branch 8 times, most recently from f582b6b to 09bf14f Compare June 25, 2025 11:27
@czosel czosel requested a review from cseufert June 25, 2025 11:31
@czosel
Copy link
Collaborator Author

czosel commented Jun 27, 2025

I'll go ahead and merge this, should not be too controversial.

@czosel czosel merged commit 81991b2 into main Jun 27, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants