Enhance release list #6025

adelowo · 2019-02-09T21:17:52Z

If the email of the tag commit belongs to a user, make the user the publisher else do nothing ( current behavior)
For tags pushed to Gitea, show the number of commits behind the master branch - as is done for releases created via the UI

codecov-io · 2019-02-09T21:27:22Z

Codecov Report

❗ No coverage uploaded for pull request base (master@eb4c10d). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #6025   +/-   ##
=========================================
  Coverage          ?   41.26%           
=========================================
  Files             ?      570           
  Lines             ?    74398           
  Branches          ?        0           
=========================================
  Hits              ?    30703           
  Misses            ?    39868           
  Partials          ?     3827

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb4c10d...19a6d50. Read the comment docs.

models/release.go

markusamshove · 2019-02-11T09:07:58Z

Does "commits behind" default to master or default branch? The latter would be better IMO :-)

adelowo · 2019-02-11T09:31:44Z

It defaults to the default branch

Also show the number of commits behind the default branch for tags created outside the UI don't show the tag date again for tags pushed to the repo. Since it is already on the sidebar and looks like duplication

adelowo · 2019-03-28T17:21:54Z

Ready for review :)

models/migrations/v83.go

kolaente

Please resolve conflicts, looks good otherwise.

stale · 2019-08-04T02:00:41Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

lunny · 2019-11-16T09:20:50Z

Please resolve the conflicts.

lunny · 2019-12-14T01:03:53Z

Please resolve the conflicts.

adelowo · 2019-12-14T08:41:08Z

Will do this weekend

zeripath

Gitrepos aren't always closed if there is an error. You must ensure that they're closed.

richmahn · 2020-10-13T20:19:54Z

@adelowo Looks like we have conflicts again, and the defer issue mentioned above.

…se_list

codecov-io · 2020-10-15T21:24:02Z

Codecov Report

Merging #6025 into master will decrease coverage by 0.04%.
The diff coverage is 4.81%.

@@            Coverage Diff             @@
##           master    #6025      +/-   ##
==========================================
- Coverage   42.21%   42.17%   -0.05%     
==========================================
  Files         683      684       +1     
  Lines       75458    75541      +83     
==========================================
+ Hits        31858    31860       +2     
- Misses      38377    38456      +79     
- Partials     5223     5225       +2

Impacted Files	Coverage Δ
models/migrations/migrations.go	`2.44% <ø> (ø)`
models/migrations/v156.go	`0.00% <0.00%> (ø)`
routers/repo/release.go	`26.72% <100.00%> (+0.31%)`	⬆️
services/release/release.go	`31.31% <100.00%> (+2.14%)`	⬆️
modules/util/timer.go	`42.85% <0.00%> (-42.86%)`	⬇️
modules/queue/unique_queue_disk_channel.go	`53.84% <0.00%> (-1.54%)`	⬇️
modules/queue/workerpool.go	`59.18% <0.00%> (-0.82%)`	⬇️
services/pull/check.go	`48.90% <0.00%> (-0.73%)`	⬇️
services/pull/pull.go	`40.78% <0.00%> (ø)`
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9658610...4d85686. Read the comment docs.

adelowo · 2020-10-15T21:44:47Z

Ready for review

models/migrations/v156.go

zeripath · 2020-10-18T14:11:45Z

@lunny would you like to re-review?

Out of date

techknowlogick · 2020-10-22T00:55:18Z

🚀

lunny · 2020-10-22T05:35:29Z

@zeripath Sorry I missed this PR, I send another PR, please see #13254 .

lunny · 2020-11-03T08:53:12Z

models/migrations/v156.go

+				continue
+			}
+
+			release.PublisherID = u.ID


This maybe override the original PublisherID, @adelowo why we need that?

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 9, 2019

lafriks added the type/enhancement An improvement of existing functionality label Feb 9, 2019

lafriks reviewed Feb 9, 2019

View reviewed changes

models/release.go Outdated Show resolved Hide resolved

techknowlogick added this to the 1.9.0 milestone Feb 11, 2019

adelowo added 2 commits March 28, 2019 17:30

show author for releases created outside Gitea UI.

5f123b0

Also show the number of commits behind the default branch for tags created outside the UI don't show the tag date again for tags pushed to the repo. Since it is already on the sidebar and looks like duplication

add migration for already existing tags

09fef96

adelowo force-pushed the enhance_release_list branch from d476ab9 to 09fef96 Compare March 28, 2019 17:21

lunny reviewed Mar 29, 2019

View reviewed changes

models/migrations/v83.go Outdated Show resolved Hide resolved

lunny requested changes Mar 29, 2019

View reviewed changes

models/migrations/v83.go Outdated Show resolved Hide resolved

adelowo added 2 commits March 29, 2019 22:20

update as per review

b453340

fix merge conflicts

f985e2c

adelowo force-pushed the enhance_release_list branch from 7edee68 to f985e2c Compare May 1, 2019 16:32

Merge remote-tracking branch 'origin' into enhance_release_list

92b7dfd

kolaente suggested changes May 13, 2019

View reviewed changes

techknowlogick modified the milestones: 1.9.0, 1.10.0 Jun 4, 2019

stale bot added the issue/stale label Aug 4, 2019

lunny added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Aug 4, 2019

stale bot removed the issue/stale label Aug 4, 2019

lunny modified the milestones: 1.10.0, 1.11.0 Sep 15, 2019

Merge remote-tracking branch 'origin' into enhance_release_list

e50fe8d

zeripath suggested changes Sep 2, 2020

View reviewed changes

lunny modified the milestones: 1.13.0, 1.14.0 Sep 10, 2020

6543 and others added 3 commits October 14, 2020 03:38

Merge branch 'master' into enhance_release_list

78dceb3

remove dependency on models package

5a3fb34

Merge branch 'master' of github.com:go-gitea/gitea into enhance_relea…

4f61e67

…se_list

Merge branch 'master' into enhance_release_list

79c144d

zeripath reviewed Oct 18, 2020

View reviewed changes

models/migrations/v156.go Outdated Show resolved Hide resolved

models/migrations/v156.go Outdated Show resolved Hide resolved

Close the gitrepos in a defer to ensure that they are closed.

5688b34

zeripath approved these changes Oct 18, 2020

View reviewed changes

6543 and others added 5 commits October 18, 2020 16:50

Merge branch 'master' into enhance_release_list

4158361

Merge branch 'master' into enhance_release_list

3b1541f

gofmt

d7ff241

Merge branch 'master' into enhance_release_list

19d43d5

Merge branch 'master' into enhance_release_list

0ad085d

techknowlogick and others added 2 commits October 20, 2020 19:50

Merge branch 'master' into enhance_release_list

4d85686

Merge branch 'master' into enhance_release_list

f90eb0f

techknowlogick merged commit e918636 into go-gitea:master Oct 22, 2020

wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf mentioned this pull request Oct 22, 2020

Issue with recent Migration[156] #13255

Closed

4 tasks

6543 deleted the enhance_release_list branch October 22, 2020 09:50

lunny reviewed Nov 3, 2020

View reviewed changes

go-gitea locked and limited conversation to collaborators Nov 24, 2020

Uh oh!

Enhance release list #6025

Enhance release list #6025

Uh oh!

Conversation

adelowo commented Feb 9, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-io commented Feb 9, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

markusamshove commented Feb 11, 2019

Uh oh!

adelowo commented Feb 11, 2019

Uh oh!

adelowo commented Mar 28, 2019

Uh oh!

Uh oh!

Uh oh!

kolaente left a comment

Choose a reason for hiding this comment

Uh oh!

stale bot commented Aug 4, 2019

Uh oh!

lunny commented Nov 16, 2019

Uh oh!

lunny commented Dec 14, 2019

Uh oh!

adelowo commented Dec 14, 2019

Uh oh!

zeripath left a comment

Choose a reason for hiding this comment

Uh oh!

richmahn commented Oct 13, 2020

Uh oh!

codecov-io commented Oct 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

adelowo commented Oct 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zeripath commented Oct 18, 2020

Uh oh!

techknowlogick commented Oct 22, 2020

Uh oh!

lunny commented Oct 22, 2020

Uh oh!

lunny Nov 3, 2020

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

adelowo commented Feb 9, 2019 •

edited

Loading

codecov-io commented Feb 9, 2019 •

edited

Loading

codecov-io commented Oct 15, 2020 •

edited

Loading

adelowo commented Oct 15, 2020 •

edited

Loading