x/tools/gopls: allow more formatter options

[yzhou216]

Proposal Details

Currently, in the gopls settings, we only have the option to enable gofumpt. It would be nice if gopls allows the user to set a path to a specific formatter program like how nil implements it, where it supports setting a custom formatter in the config by assigning the path of the formatter to "nil"."formatter"."command" as a String. This would enable the ability to use third party formatters such as golines and golangci-lint fmt with gopls.

[gabyhelp]

Related Issues

• x/tools/gopls: allow enabling gofumpt extra rules #56403

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

[adonovan]

Though I don't love the idea of further complicating what should be a simple story ("there is one format and its command is gofmt"), I would support this feature if it meant that gopls could avoid linking in gofumpt, instead being loosely coupled to nonstandard formatters through a common command-line interface. Then gofumpt=true could become a shorthand for formatter=github.com/mvdan/gofumpt.