Skip to content

Commit daf9460

Browse files
adonovangopherbot
authored andcommitted
Revert "gopls/internal/test/integration/misc: reenable staticcheck test"
This reverts commit 618670d. Reason for revert: The test does not in fact pass, but this was obscured by a bug (?) in the godebug machinery, which uses a default value poked into the executable at link-time of "...gotypesalias=0...", which means the default value is not "on", as we thought when we changed the interpretation of unset to mean "on". Change-Id: Ib45b230a80d8b52a9d69db56025dae34add29fb8 Reviewed-on: https://go-review.googlesource.com/c/tools/+/579757 Auto-Submit: Alan Donovan <adonovan@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Robert Findley <rfindley@google.com>
1 parent 618670d commit daf9460

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

gopls/internal/test/integration/misc/staticcheck_test.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,9 @@ import (
1515
func TestStaticcheckGenerics(t *testing.T) {
1616
testenv.NeedsGo1Point(t, 20) // staticcheck requires go1.20+
1717

18+
// TODO(golang/go#65249): re-enable and fix this test with gotypesalias=1.
19+
testenv.SkipMaterializedAliases(t, "staticcheck needs updates for materialized aliases")
20+
1821
const files = `
1922
-- go.mod --
2023
module mod.com
@@ -80,6 +83,9 @@ var FooErr error = errors.New("foo")
8083
func TestStaticcheckRelatedInfo(t *testing.T) {
8184
testenv.NeedsGo1Point(t, 20) // staticcheck is only supported at Go 1.20+
8285

86+
// TODO(golang/go#65249): re-enable and fix this test with gotypesalias=1.
87+
testenv.SkipMaterializedAliases(t, "staticcheck needs updates for materialized aliases")
88+
8389
const files = `
8490
-- go.mod --
8591
module mod.test

0 commit comments

Comments
 (0)