Stop generating unnecessary new. (#1357)

Author: davidmorgan

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+# 8.10.0
+
+- Stop generating unnecessary `new` keywords.
+
 # 8.9.5
 
 - Allow `built_value_generator` to use `analyzer 7.0.0`.

benchmark/lib/node.g.dart

@@ -205,7 +205,7 @@ abstract class EnumSourceClass
 
     var fallback = fields.firstWhereOrNull((field) => field.settings.fallback);
     if (fallback == null) {
-      result.writeln('default: throw new ArgumentError(name);');
+      result.writeln('default: throw ArgumentError(name);');
     } else {
       result.writeln('default: return ${fallback.generatedIdentifier};');
     }
@@ -214,7 +214,7 @@ abstract class EnumSourceClass
     result.writeln('');
 
     result.writeln('final BuiltSet<$name> $valuesIdentifier ='
-        'new BuiltSet<$name>(const <$name>[');
+        'BuiltSet<$name>(const <$name>[');
     for (var field in fields) {
       result.writeln('${field.generatedIdentifier},');
     }

benchmark/lib/simple_value.g.dart

@@ -295,7 +295,7 @@ abstract class SerializerSourceClass
   }
 
   String generateSerializerDeclaration() =>
-      'Serializer<$genericName> $serializerInstanceName = new $serializerImplName();';
+      'Serializer<$genericName> $serializerInstanceName = $serializerImplName();';
 
   /// Returns the class name for the generated implementation. If the manually
   /// maintained class is private then we ignore the underscore here, to avoid
@@ -441,10 +441,10 @@ class $serializerImplName implements PrimitiveSerializer<$genericName> {
   String _generateNewBuilder() {
     var parameters = _genericParametersUsedInFields;
     if (parameters.isEmpty) {
-      return 'new ${name}Builder$genericBoundsOrObjectString()';
+      return '${name}Builder$genericBoundsOrObjectString()';
     }
     return 'isUnderspecified ? '
-        'new ${name}Builder$genericBoundsOrObjectString() : '
+        '${name}Builder$genericBoundsOrObjectString() : '
         'serializers.newBuilder(specifiedType) as '
         '${name}Builder$genericBoundsOrObjectString';
   }