Skip to content

Commit 4c9e1e6

Browse files
authored
CI fix to handle analyzer/SDK language version changing (#1513)
* fix lint
1 parent e1381aa commit 4c9e1e6

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

json_serializable/test/annotation_version_test.dart

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,15 @@ class SomeClass{}
189189
}
190190

191191
final output = lines.toString();
192-
final expectedWarningCount = message == null ? 0 : 1;
192+
var expectedWarningCount = message == null ? 0 : 1;
193+
194+
// If pkg:analyzer is out of sync with the current SDK, we can get a warning
195+
// about the "SDK language version". In that case, just expect one more
196+
// warning and proceed.
197+
if (output.contains('W SDK language version ')) {
198+
expectedWarningCount++;
199+
}
200+
193201
final warningCount = _warningStartOfLine.allMatches(output).length;
194202
expect(
195203
warningCount,

json_serializable/test/src/inheritance_test_input.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,7 @@ class SubTypeWithAnnotatedFieldOverrideExtendsWithOverrides extends SuperType {
8181
int? get superReadWriteField => super.superReadWriteField;
8282

8383
@override
84+
// ignore: unnecessary_overrides
8485
set superReadWriteField(int? value) {
8586
super.superReadWriteField = value;
8687
}

0 commit comments

Comments
 (0)