Skip to content

Conversation

@VickyTheViking
Copy link
Contributor

@VickyTheViking VickyTheViking changed the title Dtable query method code injection D-tale query method code injection Aug 5, 2025
@giacomo-doyensec
Copy link
Contributor

Hello @VickyTheViking, thank you for your contribution!
Could you also provide safe setup instructions in addition to the current ones?

Copy link
Contributor

@giacomo-doyensec giacomo-doyensec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some additional comments and suggestions, feel free to reach out for any doubt or question!

@@ -0,0 +1,21 @@
# setup a D-Tale inance without need of authentication
```bash
cd Vulnerable/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cd Vulnerable/

@@ -0,0 +1,11 @@
FROM python:3.7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not build correctly on my machine, I bumped it to python:3.10 and it builds without issues now. Was there any specific reason to leave it to 3.7?

Suggested change
FROM python:3.7
FROM python:3.10

Comment on lines 10 to 14
curl 'http://127.0.0.1:40000/dtale/upload' \
-X POST \
-H 'Content-Type: multipart/form-data; boundary=----geckoformboundaryb38fffc548bd5dad82328985c3f223d4' \
--data-binary \
$'------geckoformboundaryb38fffc548bd5dad82328985c3f223d4\r\nContent-Disposition: form-data; name="simple-dtale-data.csv"; filename="simple-dtale-data.csv"\r\nContent-Type: text/csv\r\n\r\n------geckoformboundaryb38fffc548bd5dad82328985c3f223d4\r\nContent-Disposition: form-data; name="header"\r\n\r\ntrue\r\n------geckoformboundaryb38fffc548bd5dad82328985c3f223d4\r\nContent-Disposition: form-data; name="separatorType"\r\n\r\ncomma\r\n------geckoformboundaryb38fffc548bd5dad82328985c3f223d4\r\nContent-Disposition: form-data; name="separator"\r\n\r\n\r\n------geckoformboundaryb38fffc548bd5dad82328985c3f223d4--\r\n'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get the same issue of the detector, already commented it here: google/tsunami-security-scanner-plugins#673 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants