Skip to content

Could you modify README.md for streamId of WriterOptions? #618

@rnotorni

Description

@rnotorni

Please make sure you have searched for information in the following guides.

Documentation Request

I think it is better to delete streamId in JSONWriter constructor in README.md

README.md is writed about blew.

    const streamId = connection.getStreamId();

    const writer = new JSONWriter({
      streamId,
      connection,
      protoDescriptor,
    });

But WriterOptions has not streamId of properties and JSONWriter not use streamId.
https://github.com/googleapis/nodejs-bigquery-storage/blob/v5.1.0/src/managedwriter/writer.ts#L36

So, if we use typescript, then it occures error of typescript.

I think it is better to delete streamId of JSONWriter in README.md if we don't use it in the future

Thank you for your reading this issue 🙇

If there is a common understanding and no one is available, I will create a PR for README.md and related documents.

Metadata

Metadata

Assignees

No one assigned

    Labels

    api: bigquerystorageIssues related to the googleapis/nodejs-bigquery-storage API.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions