From ea8f327eb5eb2c2fd053de63ec282f886dde1582 Mon Sep 17 00:00:00 2001 From: Owl Bot Date: Fri, 21 Nov 2025 20:28:19 +0000 Subject: [PATCH] chore: lint failures Source-Link: https://github.com/googleapis/synthtool/commit/7751597471a34c54d67f225b3852e86c35d605b8 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:a1e45c1b53fceb5fa7fd5c49cf898048c210eb07001a3355548e7a4545200ee8 --- .github/.OwlBot.lock.yaml | 4 ++-- .github/workflows/ci.yaml | 33 +++++++++++++------------- .github/workflows/issues-no-repro.yaml | 2 +- .kokoro/lint.sh | 5 ++++ .kokoro/release/publish.cfg | 2 +- README.md | 2 +- protos/protos.json | 9 ++++++- renovate.json | 4 ++++ 8 files changed, 38 insertions(+), 23 deletions(-) diff --git a/.github/.OwlBot.lock.yaml b/.github/.OwlBot.lock.yaml index 3037bc54..3a1abb94 100644 --- a/.github/.OwlBot.lock.yaml +++ b/.github/.OwlBot.lock.yaml @@ -13,5 +13,5 @@ # limitations under the License. docker: image: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest - digest: sha256:b612d739b0533e56ba174526ca339f264b63e911c30d6f83f55b57c38cc6ad2a -# created: 2025-08-15T12:36:48.871481111Z + digest: sha256:a1e45c1b53fceb5fa7fd5c49cf898048c210eb07001a3355548e7a4545200ee8 +# created: 2025-11-21T20:24:19.347250905Z diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 5de63476..87f50077 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -12,7 +12,7 @@ jobs: node: [18, 20, 22, 24] steps: - uses: actions/checkout@v5 - - uses: actions/setup-node@v4 + - uses: actions/setup-node@v6 with: node-version: ${{ matrix.node }} - run: node --version @@ -30,7 +30,7 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v5 - - uses: actions/setup-node@v4 + - uses: actions/setup-node@v6 with: node-version: 18 - run: node --version @@ -44,7 +44,7 @@ jobs: runs-on: windows-latest steps: - uses: actions/checkout@v5 - - uses: actions/setup-node@v4 + - uses: actions/setup-node@v6 with: node-version: 18 - run: npm install --engine-strict @@ -55,21 +55,20 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v5 - - uses: actions/setup-node@v4 + - uses: actions/setup-node@v6 with: node-version: 18 - run: npm install - run: npm run lint - # TODO(https://github.com/googleapis/nodejs-bigquery-storage/issues/624) - # docs: - # runs-on: ubuntu-latest - # steps: - # - uses: actions/checkout@v5 - # - uses: actions/setup-node@v4 - # with: - # node-version: 18 - # - run: npm install - # - run: npm run docs - # - uses: JustinBeckwith/linkinator-action@v1 - # with: - # paths: docs/ + docs: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v5 + - uses: actions/setup-node@v6 + with: + node-version: 18 + - run: npm install + - run: npm run docs + - uses: JustinBeckwith/linkinator-action@v1 + with: + paths: docs/ diff --git a/.github/workflows/issues-no-repro.yaml b/.github/workflows/issues-no-repro.yaml index 53105402..66ceadb9 100644 --- a/.github/workflows/issues-no-repro.yaml +++ b/.github/workflows/issues-no-repro.yaml @@ -11,7 +11,7 @@ jobs: pull-requests: write steps: - uses: actions/checkout@v5 - - uses: actions/setup-node@v4 + - uses: actions/setup-node@v6 with: node-version: 18 - run: npm install diff --git a/.kokoro/lint.sh b/.kokoro/lint.sh index aef4866e..f994f276 100755 --- a/.kokoro/lint.sh +++ b/.kokoro/lint.sh @@ -17,6 +17,11 @@ set -eo pipefail export NPM_CONFIG_PREFIX=${HOME}/.npm-global +export PATH="${NPM_CONFIG_PREFIX}/bin:${PATH}" + +# Ensure the npm global directory is writable, otherwise rebuild `npm` +mkdir -p ${NPM_CONFIG_PREFIX} +npm config -g ls || npm i -g npm@`npm --version` cd $(dirname $0)/.. diff --git a/.kokoro/release/publish.cfg b/.kokoro/release/publish.cfg index 1ab8d3f8..b5e5ea5d 100644 --- a/.kokoro/release/publish.cfg +++ b/.kokoro/release/publish.cfg @@ -38,7 +38,7 @@ env_vars: { value: "github/nodejs-bigquery-storage/.kokoro/publish.sh" } -# Store the packages we uploaded to npmjs.org and their corresponding +# Store the packages we uploaded to npmjs.com and their corresponding # package-lock.jsons in Placer. That way, we have a record of exactly # what we published, and which version of which tools we used to publish # it, which we can use to generate SBOMs and attestations. diff --git a/README.md b/README.md index 97782baa..88ef3916 100644 --- a/README.md +++ b/README.md @@ -5,7 +5,7 @@ # [Google BigQuery Storage: Node.js Client](https://github.com/googleapis/nodejs-bigquery-storage) [![release level](https://img.shields.io/badge/release%20level-stable-brightgreen.svg?style=flat)](https://cloud.google.com/terms/launch-stages) -[![npm version](https://img.shields.io/npm/v/@google-cloud/bigquery-storage.svg)](https://www.npmjs.org/package/@google-cloud/bigquery-storage) +[![npm version](https://img.shields.io/npm/v/@google-cloud/bigquery-storage.svg)](https://www.npmjs.com/package/@google-cloud/bigquery-storage) diff --git a/protos/protos.json b/protos/protos.json index 0307c1da..450b5bef 100644 --- a/protos/protos.json +++ b/protos/protos.json @@ -3150,7 +3150,14 @@ "type": "ServiceOptions", "id": 3 } - } + }, + "reserved": [ + [ + 4, + 4 + ], + "stream" + ] }, "MethodDescriptorProto": { "edition": "proto2", diff --git a/renovate.json b/renovate.json index c5c702cf..f39fd323 100644 --- a/renovate.json +++ b/renovate.json @@ -15,6 +15,10 @@ { "extends": "packages:linters", "groupName": "linters" + }, + { + "matchManagers": ["github-actions"], + "enabled": false } ], "ignoreDeps": ["typescript"]