From 2f497ee4f8b7f1bfb013628ebe19ef65d2b339a7 Mon Sep 17 00:00:00 2001 From: A Vertex SDK engineer Date: Fri, 31 Oct 2025 02:57:51 -0700 Subject: [PATCH] chore: add cloud.platform attribute to OTel resource This applies to ADK Apps on Agent Engine and follows https://github.com/open-telemetry/semantic-conventions/pull/2957. PiperOrigin-RevId: 826404720 --- tests/unit/vertex_adk/test_agent_engine_templates_adk.py | 1 + tests/unit/vertex_adk/test_reasoning_engine_templates_adk.py | 1 + vertexai/agent_engines/templates/adk.py | 1 + vertexai/preview/reasoning_engines/templates/adk.py | 1 + 4 files changed, 4 insertions(+) diff --git a/tests/unit/vertex_adk/test_agent_engine_templates_adk.py b/tests/unit/vertex_adk/test_agent_engine_templates_adk.py index af89d0ea33..2b5d8fab21 100644 --- a/tests/unit/vertex_adk/test_agent_engine_templates_adk.py +++ b/tests/unit/vertex_adk/test_agent_engine_templates_adk.py @@ -609,6 +609,7 @@ def test_tracing_setup( "telemetry.sdk.version": "1.36.0", "gcp.project_id": "test-project", "cloud.account.id": "test-project", + "cloud.platform": "gcp.agent_engine", "service.name": "test_agent_id", "cloud.resource_id": "//aiplatform.googleapis.com/projects/test-project/locations/us-central1/reasoningEngines/test_agent_id", "service.instance.id": "12345678123456781234567812345678-123123123", diff --git a/tests/unit/vertex_adk/test_reasoning_engine_templates_adk.py b/tests/unit/vertex_adk/test_reasoning_engine_templates_adk.py index c6e9c02e7c..6ce5222114 100644 --- a/tests/unit/vertex_adk/test_reasoning_engine_templates_adk.py +++ b/tests/unit/vertex_adk/test_reasoning_engine_templates_adk.py @@ -636,6 +636,7 @@ def test_tracing_setup( "telemetry.sdk.version": "1.36.0", "gcp.project_id": "test-project", "cloud.account.id": "test-project", + "cloud.platform": "gcp.agent_engine", "service.name": "test_agent_id", "cloud.resource_id": "//aiplatform.googleapis.com/projects/test-project/locations/us-central1/reasoningEngines/test_agent_id", "service.instance.id": "12345678123456781234567812345678-123123123", diff --git a/vertexai/agent_engines/templates/adk.py b/vertexai/agent_engines/templates/adk.py index b517f7ce4c..c16aed3a1a 100644 --- a/vertexai/agent_engines/templates/adk.py +++ b/vertexai/agent_engines/templates/adk.py @@ -320,6 +320,7 @@ def _detect_cloud_resource_id(project_id: str) -> Optional[str]: attributes={ "gcp.project_id": project_id, "cloud.account.id": project_id, + "cloud.platform": "gcp.agent_engine", "service.name": os.getenv("GOOGLE_CLOUD_AGENT_ENGINE_ID", ""), "service.instance.id": f"{uuid.uuid4().hex}-{os.getpid()}", "cloud.region": os.getenv("GOOGLE_CLOUD_LOCATION", ""), diff --git a/vertexai/preview/reasoning_engines/templates/adk.py b/vertexai/preview/reasoning_engines/templates/adk.py index 9cc9dc876c..a4d31e5034 100644 --- a/vertexai/preview/reasoning_engines/templates/adk.py +++ b/vertexai/preview/reasoning_engines/templates/adk.py @@ -300,6 +300,7 @@ def _detect_cloud_resource_id(project_id: str) -> Optional[str]: attributes={ "gcp.project_id": project_id, "cloud.account.id": project_id, + "cloud.platform": "gcp.agent_engine", "service.name": os.getenv("GOOGLE_CLOUD_AGENT_ENGINE_ID", ""), "service.instance.id": f"{uuid.uuid4().hex}-{os.getpid()}", "cloud.region": os.getenv("GOOGLE_CLOUD_LOCATION", ""),