From e8b12cbd591951fd9d8df9016d8855c73674a9f0 Mon Sep 17 00:00:00 2001 From: Ben Kazemi Date: Fri, 21 Nov 2025 12:18:52 -0800 Subject: [PATCH] fix: GenAI SDK client(eval) - Reorder the params to put the Config param at the last place. PiperOrigin-RevId: 835315926 --- vertexai/_genai/evals.py | 14 +++++++------- vertexai/_genai/types/common.py | 8 ++++---- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/vertexai/_genai/evals.py b/vertexai/_genai/evals.py index 8a4bce18ad..b6a75e8bcd 100644 --- a/vertexai/_genai/evals.py +++ b/vertexai/_genai/evals.py @@ -81,12 +81,12 @@ def _CreateEvaluationRunParameters_to_vertex( if getv(from_object, ["labels"]) is not None: setv(to_object, ["labels"], getv(from_object, ["labels"])) - if getv(from_object, ["config"]) is not None: - setv(to_object, ["config"], getv(from_object, ["config"])) - if getv(from_object, ["inference_configs"]) is not None: setv(to_object, ["inferenceConfigs"], getv(from_object, ["inference_configs"])) + if getv(from_object, ["config"]) is not None: + setv(to_object, ["config"], getv(from_object, ["config"])) + return to_object @@ -472,10 +472,10 @@ def _create_evaluation_run( data_source: types.EvaluationRunDataSourceOrDict, evaluation_config: types.EvaluationRunConfigOrDict, labels: Optional[dict[str, str]] = None, - config: Optional[types.CreateEvaluationRunConfigOrDict] = None, inference_configs: Optional[ dict[str, types.EvaluationRunInferenceConfigOrDict] ] = None, + config: Optional[types.CreateEvaluationRunConfigOrDict] = None, ) -> types.EvaluationRun: """ Creates an EvaluationRun. @@ -487,8 +487,8 @@ def _create_evaluation_run( data_source=data_source, evaluation_config=evaluation_config, labels=labels, - config=config, inference_configs=inference_configs, + config=config, ) request_url_dict: Optional[dict[str, str]] @@ -1627,10 +1627,10 @@ async def _create_evaluation_run( data_source: types.EvaluationRunDataSourceOrDict, evaluation_config: types.EvaluationRunConfigOrDict, labels: Optional[dict[str, str]] = None, - config: Optional[types.CreateEvaluationRunConfigOrDict] = None, inference_configs: Optional[ dict[str, types.EvaluationRunInferenceConfigOrDict] ] = None, + config: Optional[types.CreateEvaluationRunConfigOrDict] = None, ) -> types.EvaluationRun: """ Creates an EvaluationRun. @@ -1642,8 +1642,8 @@ async def _create_evaluation_run( data_source=data_source, evaluation_config=evaluation_config, labels=labels, - config=config, inference_configs=inference_configs, + config=config, ) request_url_dict: Optional[dict[str, str]] diff --git a/vertexai/_genai/types/common.py b/vertexai/_genai/types/common.py index 2b6e9f0fc9..7010b2e9d5 100644 --- a/vertexai/_genai/types/common.py +++ b/vertexai/_genai/types/common.py @@ -1034,10 +1034,10 @@ class _CreateEvaluationRunParameters(_common.BaseModel): default=None, description="""""" ) labels: Optional[dict[str, str]] = Field(default=None, description="""""") - config: Optional[CreateEvaluationRunConfig] = Field( + inference_configs: Optional[dict[str, "EvaluationRunInferenceConfig"]] = Field( default=None, description="""""" ) - inference_configs: Optional[dict[str, "EvaluationRunInferenceConfig"]] = Field( + config: Optional[CreateEvaluationRunConfig] = Field( default=None, description="""""" ) @@ -1060,10 +1060,10 @@ class _CreateEvaluationRunParametersDict(TypedDict, total=False): labels: Optional[dict[str, str]] """""" - config: Optional[CreateEvaluationRunConfigDict] + inference_configs: Optional[dict[str, "EvaluationRunInferenceConfigDict"]] """""" - inference_configs: Optional[dict[str, "EvaluationRunInferenceConfigDict"]] + config: Optional[CreateEvaluationRunConfigDict] """"""