fix(gql_dedupe_link)!: do not dedupe mutations by default (#489)

Author: knaeckeKami

links/gql_dedupe_link/CHANGELOG.md

@@ -1,3 +1,8 @@
+## 3.0.0
+
+- skip deduplication for mutations by default
+- `gql` promoted to runtime dependency
+
 ## 2.0.3+1
 
 - add topics

links/gql_dedupe_link/README.md

@@ -22,6 +22,8 @@
 
 A GQL Link to deduplicate in-flight requests.
 
+By default only queries and subscriptions are deduplicated. Mutations are always forwarded.
+
 ## Usage
 
 A simple usage example:

links/gql_dedupe_link/lib/gql_dedupe_link.dart

@@ -2,6 +2,7 @@
 library gql_dedupe_link;
 
 import "package:async/async.dart";
+import "package:gql/ast.dart";
 import "package:gql_exec/gql_exec.dart";
 import "package:gql_link/gql_link.dart";
 
@@ -10,7 +11,10 @@ class DedupeLink extends Link {
   final bool Function(Request request) _shouldDedupe;
   final Map<Request, StreamSplitter<Response>> _inFlight = {};
 
-  static bool _defaultShouldDedupe(Request request) => true;
+  static bool _defaultShouldDedupe(Request request) {
+    final type = request.operation.getOperationType();
+    return type == null || type != OperationType.mutation;
+  }
 
   DedupeLink({
     bool Function(Request request) shouldDedupe = _defaultShouldDedupe,

links/gql_dedupe_link/pubspec.yaml

@@ -1,16 +1,16 @@
 name: gql_dedupe_link
-version: 2.0.3+1
+version: 3.0.0
 description: GQL Link to deduplicate identical in-flight execution requests
 repository: https://github.com/gql-dart/gql
 environment: 
   sdk: '>=2.12.0 <4.0.0'
-dependencies: 
+dependencies:
   async: ^2.5.0
+  gql: ^1.0.0
   gql_exec: ^1.0.0
   gql_link: ^1.0.0
   meta: ^1.3.0
-dev_dependencies: 
-  gql: ^1.0.0
+dev_dependencies:
   gql_pedantic: ^1.0.2
   mockito: ^5.0.0-nullsafety.7
   test: ^1.16.2

links/gql_dedupe_link/test/gql_dedupe_link_test.dart

@@ -185,6 +185,64 @@ void main() {
       expect(await return2, result1);
     });
 
+    test("does not dedupe identical mutations", () async {
+      final document = parseString(
+        """
+        mutation withVar(\$i: Int) {
+          take(i: \$i)
+        }
+      """,
+      );
+
+      final req1 = Request(
+        operation: Operation(
+          document: document,
+        ),
+        variables: const <String, dynamic>{"i": 12},
+      );
+
+      final req2 = Request(
+        operation: Operation(
+          document: document,
+        ),
+        variables: const <String, dynamic>{"i": 12},
+      );
+
+      const result1Data = <String, dynamic>{"a": 1};
+      final result1 = Response(
+        data: result1Data,
+        response: const <String, dynamic>{"data": result1Data},
+      );
+
+      final mockLink = MockLink();
+
+      when(
+        mockLink.request(req1, null),
+      ).thenAnswer(
+        (_) => Stream.fromIterable([result1]),
+      );
+
+      when(
+        mockLink.request(req2, null),
+      ).thenAnswer(
+        (_) => Stream.fromIterable([result1]),
+      );
+
+      final link = Link.from([
+        DedupeLink(),
+        mockLink,
+      ]);
+
+      final stream1 = link.request(req1);
+      final stream2 = link.request(req2);
+
+      verify(
+        mockLink.request(req1, null),
+      ).called(2);
+      expect(await stream1.first, result1);
+      expect(await stream2.first, result1);
+    });
+
     test(
         "does not dedupe identical queries if shouldDedupe is false for request",
         () async {