refactor: lint code (#39)

* fix non-constant format string error

* lint

Author: xnyo

api/api.go

@@ -81,7 +81,7 @@ func (cl Client) newRequest(ctx context.Context, method, url string) (*http.Requ
 	return req, err
 }
 
-func (cl Client) Request(ctx context.Context, method, url string, out interface{}) error {
+func (cl Client) Request(ctx context.Context, method, url string, out interface{}) (err error) {
 	req, err := cl.newRequest(ctx, method, url)
 	if err != nil {
 		return fmt.Errorf("new request: %w", err)
@@ -90,7 +90,13 @@ func (cl Client) Request(ctx context.Context, method, url string, out interface{
 	if err != nil {
 		return fmt.Errorf("do request: %w", err)
 	}
-	defer resp.Body.Close()
+	defer func() {
+		if closeErr := resp.Body.Close(); closeErr != nil {
+			if err == nil {
+				err = fmt.Errorf("close response body: %w", closeErr)
+			}
+		}
+	}()
 	if resp.StatusCode != http.StatusOK {
 		return fmt.Errorf("%w: %d", ErrBadStatusCode, resp.StatusCode)
 	}

detector/detector_test.go

@@ -156,7 +156,7 @@ func unmarshalFromFile(fn string, out any) error {
 	if err != nil {
 		return err
 	}
-	defer f.Close()
+	defer func() { _ = f.Close() }()
 	return json.NewDecoder(f).Decode(out)
 }
 

main.go

@@ -223,10 +223,10 @@ func handleReadyRequest(w http.ResponseWriter, r *http.Request, ready *atomic.Bo
 
 	if ready.Load() {
 		w.WriteHeader(http.StatusOK)
-		w.Write([]byte("Ready"))
+		_, _ = w.Write([]byte("Ready"))
 	} else {
 		w.WriteHeader(http.StatusServiceUnavailable)
-		w.Write([]byte("Not Ready"))
+		_, _ = w.Write([]byte("Not Ready"))
 	}
 }
 

output/output.go

@@ -75,7 +75,7 @@ func (o LoggerReadableOutput) Output(v []Dashboard) error {
 		}
 		o.log.Log("Found dashboard with Angular plugins %q %q:", dashboard.Title, dashboard.URL)
 		for _, detection := range dashboard.Detections {
-			o.log.Log(detection.String())
+			o.log.Log("%s", detection.String())
 		}
 	}
 	return nil