Add a test for waitForNavigation with url

ankur22 · ankur22 · commit 8639485ffe6f · 2025-07-15T16:47:52.000+01:00
diff --git a/internal/js/modules/k6/browser/tests/page_test.go b/internal/js/modules/k6/browser/tests/page_test.go
@@ -2786,3 +2786,81 @@ func TestPageMustUseNativeJavaScriptObjects(t *testing.T) {
 	_, err = page.QueryAll("#textField")
 	require.NoErrorf(t, err, "page should not override the native objects, but it did")
 }
+
+func TestWaitForNavigationWithURL(t *testing.T) {
+	t.Parallel()
+
+	tb := newTestBrowser(t, withFileServer())
+	tb.vu.ActivateVU()
+	tb.vu.StartIteration(t)
+
+	got := tb.vu.RunPromise(t, `
+		const page = await browser.newPage();
+		const testURL = '%s';
+
+		try {
+			await page.goto(testURL);
+
+			// Test exact URL match
+			await Promise.all([
+				page.waitForNavigation({ url: '%s' }),
+				page.click('#page1')
+			]);
+			let currentURL = page.url();
+			if (!currentURL.endsWith('page1.html')) {
+				throw new Error('Expected to navigate to page1.html but got ' + currentURL);
+			}
+
+			await page.goto(testURL);
+
+			// Test regex pattern - matches any page with .html extension
+			await Promise.all([
+				page.waitForNavigation({ url: /.*\.html$/ }),
+				page.click('#page2')
+			]);
+			currentURL = page.url();
+			if (!currentURL.endsWith('.html')) {
+				throw new Error('Expected URL to end with .html but got ' + currentURL);
+			}
+
+			await page.goto(testURL);
+
+			// Test timeout when URL doesn't match
+			let timedOut = false;
+			try {
+				await Promise.all([
+					page.waitForNavigation({ url: /.*nonexistent.html$/, timeout: 500 }),
+					page.click('#page1')  // This goes to page1.html, not nonexistent.html
+				]);
+			} catch (error) {
+				if (error.toString().includes('waiting for navigation')) {
+					timedOut = true;
+				} else {
+					throw error;
+				}
+			}
+			if (!timedOut) {
+				throw new Error('Expected timeout error when URL does not match');
+			}
+
+			await page.goto(testURL);
+
+			// Test empty pattern (matches any navigation)
+			await Promise.all([
+				page.waitForNavigation({ url: '' }),
+				page.click('#page2')
+			]);
+			currentURL = page.url();
+			if (!currentURL.endsWith('page2.html')) {
+				throw new Error('Expected empty pattern to match any navigation but got ' + currentURL);
+			}
+		} finally {
+			// Must call close() which will clean up the taskqueue.
+			await page.close();
+		}
+	`,
+		tb.staticURL("waitfornavigation_test.html"),
+		tb.staticURL("page1.html"),
+	)
+	assert.Equal(t, sobek.Undefined(), got.Result())
+}
diff --git a/internal/js/modules/k6/browser/tests/static/waitfornavigation_test.html b/internal/js/modules/k6/browser/tests/static/waitfornavigation_test.html
@@ -0,0 +1,25 @@
+<!DOCTYPE html>
+<html>
+<head>
+    <title>WaitForNavigation Test</title>
+</head>
+<body>
+    <h1>Navigation Test Page</h1>
+    
+    <div id="links">
+        <a id="page1" href="page1.html">Go to Page 1</a><br>
+        <a id="page2" href="page2.html">Go to Page 2</a><br>
+        <a id="page1-query" href="page1.html?test=true">Page 1 with Query</a><br>
+        <a id="page2-query" href="page2.html?test=true">Page 2 with Query</a><br>
+        <a id="page1-hash" href="page1.html#section">Page 1 with Hash</a><br>
+        <a id="external" href="https://example.com/page">External Link</a><br>
+    </div>
+    
+    <script>
+        // For testing navigation via JavaScript
+        function navigateTo(url) {
+            window.location.href = url;
+        }
+    </script>
+</body>
+</html> 
