-
Notifications
You must be signed in to change notification settings - Fork 654
screenshotter: update chromedp #13066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the current version doesn't compile when building the container: <details> ``` Cleaning up Docker setup Network mixin-serve not found or has active endpoints Cleaned up Docker setup Building Docker image mixin-screenshots-taker [+] Building 9.7s (14/15) docker:orbstack => [internal] load build definition from Dockerfile 0.1s => => transferring dockerfile: 826B 0.0s => [internal] load metadata for docker.io/grafana/mimir-build-image:latest 0.0s => [internal] load metadata for docker.io/library/debian:bullseye-slim 1.7s => [auth] library/debian:pull token for registry-1.docker.io 0.0s => [internal] load .dockerignore 0.0s => => transferring context: 2B 0.0s => [builder 1/6] FROM docker.io/grafana/mimir-build-image:latest 0.2s => [stage-1 1/3] FROM docker.io/library/debian:bullseye-slim@sha256:f807f4b16002c623115b0247dca6a55 2.2s => => resolve docker.io/library/debian:bullseye-slim@sha256:f807f4b16002c623115b0247dca6a55711c6b1a 0.0s => => sha256:f807f4b16002c623115b0247dca6a55711c6b1ae821dc64fb8a2339e4ce2115d 4.54kB / 4.54kB 0.0s => => sha256:6c42e2202aeb01cbc556b99ee55169746a7dbe677f9c6baf231f6039c623c298 1.04kB / 1.04kB 0.0s => => sha256:6b31cd98ab39dad101aae699a0d3856094f48233bbaa571451ad2eb178e1878f 468B / 468B 0.0s => => sha256:93b0b88e50eb7468103e583a7be2e8ee3fe5f86e6c74df4baca40a3685b5eee1 28.75MB / 28.75MB 1.3s => => extracting sha256:93b0b88e50eb7468103e583a7be2e8ee3fe5f86e6c74df4baca40a3685b5eee1 0.8s => [internal] load build context 0.1s => => transferring context: 12.21kB 0.0s => [builder 2/6] WORKDIR /app 0.0s => [builder 3/6] COPY go.mod go.sum ./ 0.0s => [builder 4/6] RUN go mod download 2.5s => CANCELED [stage-1 2/3] RUN apt-get update && apt-get install -y chromium libnss3 lib 5.6s => [builder 5/6] COPY main.go ./ 0.0s => ERROR [builder 6/6] RUN CGO_ENABLED=0 go build -o mimir-mixin-screenshots main.go 4.9s ------ > [builder 6/6] RUN CGO_ENABLED=0 go build -o mimir-mixin-screenshots main.go: 4.622 # github.com/chromedp/chromedp 4.622 /go/pkg/mod/github.com/chromedp/chromedp@v0.10.0/chromedp.go:192:44: cannot use c.Browser (variable of type *Browser) as cdp.Executor value in argument to cdp.WithExecutor: *Browser does not implement cdp.Executor (wrong type for method Execute) 4.622 have Execute(context.Context, string, easyjson.Marshaler, easyjson.Unmarshaler) error 4.622 want Execute(context.Context, string, any, any) error 4.622 /go/pkg/mod/github.com/chromedp/chromedp@v0.10.0/chromedp.go:335:49: cannot use c.Target (variable of type *Target) as cdp.Executor value in argument to cdp.WithExecutor: *Target does not implement cdp.Executor (wrong type for method Execute) 4.622 have Execute(context.Context, string, easyjson.Marshaler, easyjson.Unmarshaler) error 4.622 want Execute(context.Context, string, any, any) error 4.622 /go/pkg/mod/github.com/chromedp/chromedp@v0.10.0/chromedp.go:350:62: cannot use c.Target (variable of type *Target) as cdp.Executor value in argument to cdp.WithExecutor: *Target does not implement cdp.Executor (wrong type for method Execute) 4.622 have Execute(context.Context, string, easyjson.Marshaler, easyjson.Unmarshaler) error 4.622 want Execute(context.Context, string, any, any) error 4.622 /go/pkg/mod/github.com/chromedp/chromedp@v0.10.0/chromedp.go:366:44: cannot use c.Browser (variable of type *Browser) as cdp.Executor value in argument to cdp.WithExecutor: *Browser does not implement cdp.Executor (wrong type for method Execute) 4.622 have Execute(context.Context, string, easyjson.Marshaler, easyjson.Unmarshaler) error 4.622 want Execute(context.Context, string, any, any) error 4.622 /go/pkg/mod/github.com/chromedp/chromedp@v0.10.0/chromedp.go:414:44: cannot use c.Browser (variable of type *Browser) as cdp.Executor value in argument to cdp.WithExecutor: *Browser does not implement cdp.Executor (wrong type for method Execute) 4.622 have Execute(context.Context, string, easyjson.Marshaler, easyjson.Unmarshaler) error 4.622 want Execute(context.Context, string, any, any) error 4.622 /go/pkg/mod/github.com/chromedp/chromedp@v0.10.0/chromedp.go:426:95: cannot use c.Browser (variable of type *Browser) as cdp.Executor value in argument to cdp.WithExecutor: *Browser does not implement cdp.Executor (wrong type for method Execute) 4.622 have Execute(context.Context, string, easyjson.Marshaler, easyjson.Unmarshaler) error 4.622 want Execute(context.Context, string, any, any) error 4.622 /go/pkg/mod/github.com/chromedp/chromedp@v0.10.0/chromedp.go:442:54: cannot use c.Target (variable of type *Target) as cdp.Executor value in argument to cdp.WithExecutor: *Target does not implement cdp.Executor (wrong type for method Execute) 4.622 have Execute(context.Context, string, easyjson.Marshaler, easyjson.Unmarshaler) error 4.622 want Execute(context.Context, string, any, any) error 4.622 /go/pkg/mod/github.com/chromedp/chromedp@v0.10.0/chromedp.go:445:67: cannot use c.Target (variable of type *Target) as cdp.Executor value in argument to cdp.WithExecutor: *Target does not implement cdp.Executor (wrong type for method Execute) 4.622 have Execute(context.Context, string, easyjson.Marshaler, easyjson.Unmarshaler) error 4.622 want Execute(context.Context, string, any, any) error 4.622 /go/pkg/mod/github.com/chromedp/chromedp@v0.10.0/chromedp.go:470:45: cannot use c.Target (variable of type *Target) as cdp.Executor value in argument to cdp.WithExecutor: *Target does not implement cdp.Executor (wrong type for method Execute) 4.622 have Execute(context.Context, string, easyjson.Marshaler, easyjson.Unmarshaler) error 4.622 want Execute(context.Context, string, any, any) error 4.622 /go/pkg/mod/github.com/chromedp/chromedp@v0.10.0/chromedp.go:705:54: cannot use c.Browser (variable of type *Browser) as cdp.Executor value in argument to cdp.WithExecutor: *Browser does not implement cdp.Executor (wrong type for method Execute) 4.622 have Execute(context.Context, string, easyjson.Marshaler, easyjson.Unmarshaler) error 4.622 want Execute(context.Context, string, any, any) error 4.622 /go/pkg/mod/github.com/chromedp/chromedp@v0.10.0/chromedp.go:705:54: too many errors ------ Dockerfile:8 -------------------- 6 | RUN go mod download 7 | COPY main.go ./ 8 | >>> RUN CGO_ENABLED=0 go build -o mimir-mixin-screenshots main.go 9 | 10 | FROM debian:bullseye-slim -------------------- ERROR: failed to build: failed to solve: process "/bin/sh -c CGO_ENABLED=0 go build -o mimir-mixin-screenshots main.go" did not complete successfully: exit code: 1 Cleaning up Docker setup Network mixin-serve not found or has active endpoints Cleaned up Docker setup make: *** [mixin-screenshots] Error 1 ``` </details> Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
56quarters
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the current version doesn't compile when building the container: