Skip to content

Conversation

@StephenKing
Copy link

@StephenKing StephenKing commented Nov 1, 2025

While it is documented, how to sign a private plugin, the GitHub actions in this repo don't support this.

In order to allow users the supply the rootUrls argument to npm run sign, this PR introduces a new parameter sign_root_urls, which has to be passed to the build-plugin action, which finally passes it to the package-plugin, which actually does the signing.

Let me know, if there is an alternative, easier way to achieve this.

Fixes: #37

Currently there is no way to sign a private plugin
by passing rootUrls to the sign command as adviced
in official documentation using these workflows.

Fixes: grafana#37
In order to supply --rootUrls for
the sign action, we need to enhance
pm.sh with support for passing
arguments to 'npm run'.
@CLAassistant
Copy link

CLAassistant commented Nov 1, 2025

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🔬 In review

Development

Successfully merging this pull request may close these issues.

Add input rootUrls for sign step

2 participants