feat: support signing of private plugins #177
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While it is documented, how to sign a private plugin, the GitHub actions in this repo don't support this.
In order to allow users the supply the
rootUrlsargument tonpm run sign, this PR introduces a new parametersign_root_urls, which has to be passed to thebuild-pluginaction, which finally passes it to thepackage-plugin, which actually does the signing.Let me know, if there is an alternative, easier way to achieve this.
Fixes: #37