Skip to content

server.Shutdown() should print errors #72

@leventov

Description

@leventov

zeroconf/server.go

Lines 195 to 198 in c2d1b41

// Shutdown closes all udp connections and unregisters the service
func (s *Server) Shutdown() {
s.shutdown()
}

Should be

if err := s.shutdown(); err != nil {
  log.Printf("Error shutting down the server: %v", err)
}

shutdown() itself should propagate or print errors from closing ipv4conn and ipv6conn.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions