Better changeset message (#1111)

* better message

* better message

Author: dimaMachina

.changeset/four-trains-glow.md

@@ -2,4 +2,4 @@
 '@graphql-eslint/eslint-plugin': patch
 ---
 
-fix(selection-set-depth): fix `TypeError` when suggestion tried to apply to fragment that located in different file
+fix(selection-set-depth): fix `TypeError` from ESLint suggestions, don't provide suggestions for fragment that can be in a separate file

packages/plugin/src/rules/selection-set-depth.ts

@@ -13,6 +13,7 @@ const RULE_ID = 'selection-set-depth';
 const rule: GraphQLESLintRule<[SelectionSetDepthRuleConfig]> = {
   meta: {
     type: 'suggestion',
+    // eslint-disable-next-line eslint-plugin/require-meta-has-suggestions -- optional since we can't provide fixes for fragments located in separate files
     hasSuggestions: true,
     docs: {
       category: 'Operations',
@@ -109,30 +110,32 @@ const rule: GraphQLESLintRule<[SelectionSetDepthRuleConfig]> = {
             getDocument: () => document,
             reportError(error: GraphQLError) {
               const { line, column } = error.locations[0];
+
+              const ancestors = context.getAncestors();
+              const token = (ancestors[0] as AST.Program).tokens.find(
+                token => token.loc.start.line === line && token.loc.start.column === column - 1
+              );
+
               context.report({
                 loc: {
                   line,
                   column: column - 1,
                 },
                 message: error.message,
-                suggest: [
-                  {
-                    desc: 'Remove selections',
-                    fix(fixer) {
-                      const ancestors = context.getAncestors();
-                      const token = (ancestors[0] as AST.Program).tokens.find(
-                        token => token.loc.start.line === line && token.loc.start.column === column - 1
-                      );
-                      if (!token) {
-                        return null;
-                      }
-                      const sourceCode = context.getSourceCode();
-                      const foundNode = sourceCode.getNodeByRangeIndex(token.range[0]) as any;
-                      const parentNode = foundNode.parent.parent;
-                      return fixer.remove(foundNode.kind === 'Name' ? parentNode.parent : parentNode);
+                // Don't provide suggestions for fragment that can be in a separate file
+                ...(token && {
+                  suggest: [
+                    {
+                      desc: 'Remove selections',
+                      fix(fixer) {
+                        const sourceCode = context.getSourceCode();
+                        const foundNode = sourceCode.getNodeByRangeIndex(token.range[0]) as any;
+                        const parentNode = foundNode.parent.parent;
+                        return fixer.remove(foundNode.kind === 'Name' ? parentNode.parent : parentNode);
+                      },
                     },
-                  },
-                ],
+                  ],
+                }),
               });
             },
           });