Should not GraphQL error extensions when it's wrapping an internal server error (#4116)

* Revert "Inherit GraphQL error extensions when it's wrapping an internal server error (#4093)"

This reverts commit 5f75a42.

* test

* no leak internals

* changeset

Author: enisdenjo

.changeset/loose-ideas-dream.md

@@ -0,0 +1,5 @@
+---
+'graphql-yoga': patch
+---
+
+Does not GraphQL error extensions when it's wrapping an internal server error

packages/graphql-yoga/__tests__/error-masking.spec.ts

@@ -803,10 +803,11 @@ describe('error masking', () => {
     });
   });
 
-  it('should inherit the extensions of a graphql error with original error', async () => {
+  // extensions may contain internal data and we dont want to leak it
+  it('should not inherit the extensions of a graphql error with original error', async () => {
     const wrappedError = createGraphQLError('I like tortoises', {
       extensions: {
-        code: 'SOME_ERROR', // overwriting the INTERNAL_SERVER_ERROR code
+        code: 'SOME_ERROR', // should not overwrite the INTERNAL_SERVER_ERROR code
         'x-hi': 'there',
       },
       originalError: new Error('I like turtles'),
@@ -841,8 +842,7 @@ describe('error masking', () => {
   "errors": [
     {
       "extensions": {
-        "code": "SOME_ERROR",
-        "x-hi": "there",
+        "code": "INTERNAL_SERVER_ERROR",
       },
       "locations": [
         {

packages/graphql-yoga/src/utils/mask-error.ts

@@ -42,10 +42,6 @@ export const maskError: MaskError = (
     if (error.extensions?.['http']) {
       errorExtensions['http'] = error.extensions['http'];
     }
-    for (const key in error.extensions) {
-      // this will be overwriting our extensions, this should be expected
-      errorExtensions[key] = error.extensions[key];
-    }
   } else if (isDev) {
     errorExtensions['originalError'] = serializeError(error);
   }