Skip to content

Conversation

@theguild-bot
Copy link
Collaborator

πŸ€– New release

  • hive-router-query-planner: 2.0.0 -> 2.0.1 (βœ“ API compatible changes)
  • hive-router-config: 0.0.7 -> 0.0.8 (βœ“ API compatible changes)
  • hive-router-plan-executor: 4.0.0 -> 5.0.0 (⚠ API breaking changes)
  • hive-router: 0.0.12 -> 0.0.13 (βœ“ API compatible changes)

⚠ hive-router-plan-executor breaking changes

--- failure constructible_struct_adds_field: externally-constructible struct adds field ---

Description:
A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field.
        ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.43.0/src/lints/constructible_struct_adds_field.ron

Failed in:
  field GraphQLErrorExtensions.affected_path in /tmp/.tmpxrokBs/router/lib/executor/src/response/graphql_error.rs:195

--- failure method_parameter_count_changed: pub method parameter count changed ---

Description:
A publicly-visible method now takes a different number of parameters.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.43.0/src/lints/method_parameter_count_changed.ron

Failed in:
  hive_router_plan_executor::context::ExecutionContext::handle_errors now takes 5 parameters instead of 4, in /tmp/.tmpxrokBs/router/lib/executor/src/context.rs:45
Changelog

hive-router-query-planner

2.0.1 - 2025-10-23

Fixed

  • (query-planner) inline nested fragment spreads (#502)

hive-router-config

0.0.8 - 2025-10-23

Added

  • (router) support hive as source for supergraph (#400)

Other

  • Rename default config file to router.config (#493)

hive-router-plan-executor

5.0.0 - 2025-10-23

Added

  • (router) support hive as source for supergraph (#400)

Fixed

  • (executor) handle subgraph errors with extensions correctly (#494)
  • (executor) error logging in HTTP executor (#498)
  • (ci) fail when audit tests failing (#495)
  • (executor) project scalars with object values correctly (#492)

Other

  • Add affectedPath to GraphQLErrorExtensions (#510)
  • Handle empty responses from subgraphs and failed entity calls (#500)

hive-router

0.0.13 - 2025-10-23

Added

  • (router) support hive as source for supergraph (#400)

Fixed

  • (e2e) solve flakiness of e2e tests and call shutdown when test is done (#516)
  • (router) use 503 instead of 500 when router is not ready (#512)
  • (executor) error logging in HTTP executor (#498)
  • (executor) handle subgraph errors with extensions correctly (#494)
  • (ci) fail when audit tests failing (#495)
  • (executor) project scalars with object values correctly (#492)
  • (query-planner) inline nested fragment spreads (#502)

Other

  • Remove mimalloc override feature and use v3 (#497)
  • Add affectedPath to GraphQLErrorExtensions (#510)
  • Handle empty responses from subgraphs and failed entity calls (#500)
  • Rename default config file to router.config (#493)


This PR was generated with release-plz.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @theguild-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request represents a new release for the graphql-hive/router project, featuring version updates for its key Rust crates. The most notable change is a major version bump for 'hive-router-plan-executor' due to API-breaking modifications related to error handling structures and method signatures. In addition to these updates, the release introduces new features like 'hive' supergraph source support and incorporates various fixes to enhance error handling, query planning, and overall stability across the router components.

Highlights

  • Module Version Updates: Several core modules including hive-router-query-planner, hive-router-config, hive-router-plan-executor, and hive-router have received version bumps, indicating a new release cycle for the project.
  • Breaking Changes in hive-router-plan-executor: The hive-router-plan-executor module has undergone a major version update (4.0.0 to 5.0.0) due to API breaking changes. These include the addition of an 'affected_path' field to GraphQLErrorExtensions and a change in the parameter count for the 'ExecutionContext::handle_errors' method.
  • Supergraph Source Support: New functionality has been added to support 'hive' as a source for supergraph configurations across the hive-router-config, hive-router-plan-executor, and hive-router modules.
  • Error Handling Improvements: Enhanced error handling within the executor, including correct management of subgraph errors with extensions, improved error logging in the HTTP executor, and better handling of empty responses and failed entity calls.
  • Query Planning and Scalar Projection Fixes: Addressed issues such as the inlining of nested fragment spreads in the query planner and corrected the projection of scalars with object values in the executor.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with πŸ‘ and πŸ‘Ž on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request contains automated version bumps and changelog updates for a new release, which is consistent with a standard release process. While reviewing the code being released, I identified two areas for future improvement. Since the relevant files are not in this PR's diff, I am noting them here for a follow-up. Firstly, in lib/executor/src/executors/http.rs, the #[tracing::instrument] on SubgraphExecutor::execute should be updated to #[tracing::instrument(skip_all, level = "trace", fields(subgraph_name = %self.subgraph_name))] to align with our performance style guide for hot paths. Secondly, to improve API stability, the GraphQLErrorExtensions struct in lib/executor/src/response/graphql_error.rs should be marked with #[non_exhaustive] to prevent future additions from being breaking changes. Apart from these suggestions for follow-up work, this release PR is approved.

@dotansimha dotansimha closed this Oct 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants