Commit d45186c
committed
Parameterise DataLoaderTest on DataLoader
The existing `DataLoaderTest` covers a very large range of test cases
which will be very useful to validate what is being added in #148.
To allow new `*Publisher` `DataLoader`s to leverage this without
copy-pasting, we make `DataLoaderTest` a parameterised test, using two
`DataLoader` variants:
- the stock 'List' `DataLoader`.
- the 'Mapped' `DataLoader`.
Most of the tests in `DataLoaderTest` have been retrofitted for this
parameterisation, resulting in:
- deduplicated code (many of the `MappedDataLoader` tests have the same
test cases, almost line-for-line).
- increased coverage of the `MappedDataLoader`, bolstering confidence
in subsequent changes (rather than relying on the author
understanding how everything is put together internally).1 parent 856a2b7 commit d45186c
File tree
3 files changed
+299
-338
lines changed- src/test/java/org/dataloader
3 files changed
+299
-338
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
72 | 72 | | |
73 | 73 | | |
74 | 74 | | |
| 75 | + | |
75 | 76 | | |
76 | 77 | | |
77 | 78 | | |
| |||
Lines changed: 0 additions & 184 deletions
This file was deleted.
0 commit comments