-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Use headers from previous tabs, if available #4096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 55762de The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
ping @benjie @dimaMachina |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4096 +/- ##
=======================================
Coverage 63.96% 63.96%
=======================================
Files 35 35
Lines 3086 3086
Branches 947 947
=======================================
Hits 1974 1974
Misses 1107 1107
Partials 5 5 🚀 New features to boost your workflow:
|
benjie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should copy from the active tab, not the first tab with headers.
Further, I think this would need to be opt-in if we want it to go out in a minor; so maybe add a prop to control it?
Issue
When opening a new tab and no
defaultHeadersis configured, headers are cleared. Rather than keeping the headers entered from previous tabs.Headers are often used for authorization. Having to re-enter the headers for every tab is very inconvenient.
Demo of the bug
Screen.Recording.2025-08-20.at.16.20.24.mov
Demo of the fix
Screen.Recording.2025-08-20.at.16.29.15.mov