From 9c63628cd76ac03971061c5f1ab0d860b6fe1961 Mon Sep 17 00:00:00 2001
From: Juan Jose Nicola <juan.nicola@greenbone.net>
Date: Tue, 29 Jul 2025 07:43:36 -0300
Subject: [PATCH] Docs: update documentation regarding targets

---
 docs/OSP.xml            | 27 +++++++++++----------------
 ospd/command/command.py |  2 +-
 2 files changed, 12 insertions(+), 17 deletions(-)

diff --git a/docs/OSP.xml b/docs/OSP.xml
index 42c964ea..e5925f3e 100644
--- a/docs/OSP.xml
+++ b/docs/OSP.xml
@@ -231,7 +231,7 @@ SPDX-License-Identifier: GPL-2.0-or-later
 
   <element>
     <name>targets</name>
-    <summary>List of targets</summary>
+    <summary>Includes one target element (deprecated)</summary>
     <pattern>
       <e>target</e>
     </pattern>
@@ -240,7 +240,6 @@ SPDX-License-Identifier: GPL-2.0-or-later
       <e>
         <targets>
           <target>...</target>
-          <target>...</target>
         </targets>
       </e>
     </example>
@@ -1531,7 +1530,7 @@ SPDX-License-Identifier: GPL-2.0-or-later
     </ele>
     <ele>
       <name>targets</name>
-      <summary>Contains elements that represent a target to execute a scan against. If target and port attributes are present this element is not take into account</summary>
+      <summary>Contains a single element that represent a target to execute a scan against. If target and port attributes are present this element is not take into account</summary>
     </ele>
     <response>
       <pattern>
@@ -1570,7 +1569,7 @@ SPDX-License-Identifier: GPL-2.0-or-later
       </response>
     </example>
     <example>
-      <summary>Start a new scan with multi-targets running simultaneously. Each one has a different port list and one of them has credentials for authenticated scans.</summary>
+      <summary>Start a new scan with. Target element has port list and credentials for authenticated scans.</summary>
       <request>
         <start_scan parallel='10'>
           <scanner_params>
@@ -1580,9 +1579,6 @@ SPDX-License-Identifier: GPL-2.0-or-later
             ....
           </vt_selection>
           <targets>
-            <target>
-              ...
-            </target>
             <target>
               <hosts>192.168.1.0/24</hosts>
               <ports>1,2,3,80,443</ports>
@@ -1931,14 +1927,6 @@ SPDX-License-Identifier: GPL-2.0-or-later
     </description>
     <version>1.1</version>
   </change>
-  <change>
-    <command>Scanner Parameters Types</command>
-    <summary>Type credential_up added</summary>
-    <description>
-      Introduce an aggregated type to express a username:password tuple.
-    </description>
-    <version>1.1</version>
-  </change>
   <change>
     <command>GET_PERFORMANCE</command>
     <summary>Command added</summary>
@@ -1947,5 +1935,12 @@ SPDX-License-Identifier: GPL-2.0-or-later
     </description>
     <version>1.2</version>
   </change>
-
+  <change>
+    <command>START_SCAN</command>
+    <summary>Deprecation of targets and parallel</summary>
+    <description>
+      Possibility of running multi-targets was not implemented. Currently, only the first target element is used and the following are ignored as well as parallel attribute.
+    </description>
+    <version>1.3</version>
+  </change>
 </protocol>
diff --git a/ospd/command/command.py b/ospd/command/command.py
index 3dde5811..d980bbc7 100644
--- a/ospd/command/command.py
+++ b/ospd/command/command.py
@@ -585,7 +585,7 @@ def handle_xml(self, xml: Element) -> bytes:
 
             if xml.get('parallel'):
                 logger.warning(
-                    "parallel attribute of start_scan will be ignored, sice "
+                    "parallel attribute of start_scan will be ignored, since "
                     "parallel scan is not supported by OSPd."
                 )