improve api hit

Manish Kumar Yadav · Manish Kumar Yadav · commit 5b6e0561dcd9 · 2025-02-07T17:19:36.000+05:30
diff --git a/client/src/components/Modals/AddEditModal.jsx b/client/src/components/Modals/AddEditModal.jsx
@@ -35,7 +35,7 @@ const AddEditModal = ({tab, isDialogOpen, setIsDialogOpen, data, type = 'add', o
         if (data?._id === undefined) {
             await onSave(noteData);
         } else {
-            await onSave(data?._id, noteData);
+            await onSave(data, noteData);
         }
     };
 
diff --git a/client/src/components/Modals/DetailModal.jsx b/client/src/components/Modals/DetailModal.jsx
@@ -29,10 +29,10 @@ const DetailModal = ({ sidebarItem = false, data, isDialogOpen, setIsDialogOpen,
 
     const handleStatusClick = () => {
         if (sidebarItem) {
-            handleStatus(data?._id, data?.status)
+            handleStatus(data)
             setIsDialogOpen(false)
         } else {
-            handleStatus(data?._id, data?.status)
+            handleStatus(data)
         }
     }
 
diff --git a/client/src/components/notes/NoteCard.jsx b/client/src/components/notes/NoteCard.jsx
@@ -10,7 +10,7 @@ import DetailModal from '../Modals/DetailModal';
 const NoteCard = ({
     note,
 }) => {
-    
+
     const [isDialogOpen, setIsDialogOpen] = useState(false);
     const { pinNote, removeNote, editNote } = useNote();
 
@@ -23,7 +23,7 @@ const NoteCard = ({
             <Card className="h-full transition-all ease-in-out hover:shadow-2xl cursor-pointer">
                 <CardHeader>
                     <div className="flex justify-between gap-2 mt-2 sm:mt-0">
-                        <Button variant="ghost" className="max-w-6" onClick={()=>pinNote(note?._id)}>
+                        <Button variant="ghost" className="max-w-6" onClick={() => pinNote(note?._id)}>
                             <Pin className={`h-5 w-5 ${note?.isPinned ? 'text-indigo-700' : ''}`} />
                         </Button>
                         <h6 className="text-lg font-bold w-full text-center" onClick={handledetail} >{note?.title}</h6>
diff --git a/client/src/components/notes/NoteContainer.jsx b/client/src/components/notes/NoteContainer.jsx
@@ -11,7 +11,7 @@ import { useNote } from '@/context/NoteProvider';
 const NoteContainer = ({ add = true }) => {
 
     const { toast } = useToast();
-    const { notes, getNotes, addNote } = useNote();
+    const { notes, addNote } = useNote();
     const [isDialogOpen, setIsDialogOpen] = useState(false);
     const note = {
         id: null,
@@ -34,7 +34,6 @@ const NoteContainer = ({ add = true }) => {
                             <div key={index}>
                                 <NoteCard
                                     note={note}
-                                    callbackFunction={getNotes}
                                     toast={toast}
                                 />
                             </div>
diff --git a/client/src/components/tasks/TaskLists.jsx b/client/src/components/tasks/TaskLists.jsx
@@ -34,7 +34,7 @@ const TaskLists = ({
                 </TableCell>
                 <TableCell
                     className="[&:has([role=checkbox])]:pr-2 w-[70px] select-none"
-                    onClick={() => taskOperations?.status(task?._id, task?.status)}
+                    onClick={() => taskOperations?.status(task)}
                 >
                     <div className={`flex items-center justify-end ${task.status ? 'text-green-500' : 'text-yellow-700'}`}>
                         {task.status ? 'done' : 'pending'}
diff --git a/client/src/context/NoteProvider.jsx b/client/src/context/NoteProvider.jsx
@@ -12,9 +12,9 @@ export const NoteProvider = ({ children }) => {
     const { searchText } = usePage();
 
     const getNotes = async (query = searchText) => {
-        const response = await fetchNotesService(query);
-        if (response?.status === 200) {
-            setNotes(response?.data);
+        const {status,data} = await fetchNotesService(query);
+        if (status === 200) {
+            setNotes(data);
         } else {
             toast({
                 variant: "destructive",
@@ -26,9 +26,9 @@ export const NoteProvider = ({ children }) => {
     }
 
     const addNote = async (noteData) => {
-        const response = await addNotesService(noteData)
-        if (response.status === 201) {
-            getNotes();
+        const {status,data} = await addNotesService(noteData)
+        if (status === 201) {
+            setNotes((prev) => [...prev, data])
             toast({
                 description: "Note added successfully!",
             });
@@ -45,10 +45,14 @@ export const NoteProvider = ({ children }) => {
         getNotes()
     }, [])
 
-    const editNote = async (id, noteData) => {
-        const response = await updateNotesService(id, noteData);
-        if (response?.data) {
-            getNotes();
+    const editNote = async (originalNote, updatedNote) => {
+        const { status, data } = await updateNotesService(originalNote?._id, updatedNote);
+        if (status === 200) {
+            setNotes((prev) =>
+                prev?.map((note) =>
+                    note?._id === data?._id ? data : note
+                )
+            )
             toast({
                 description: "Note edited Successfully!!",
             });
@@ -61,11 +65,10 @@ export const NoteProvider = ({ children }) => {
         }
     }
 
-
     const removeNote = async (id) => {
-        const response = await removeNotesService(id);
-        if (response?.data) {
-            getNotes();
+        const {status} = await removeNotesService(id);
+        if (status===200) {
+            setNotes((prevNotes) => prevNotes.filter((note) => note._id !== id));
             toast({
                 description: "Note removed Successfully!",
             });
@@ -80,11 +83,16 @@ export const NoteProvider = ({ children }) => {
 
     const pinNote = async (id) => {
 
-        const response = await pinNotesService(id);
-        if (response?.data) {
-            getNotes();
+        const {status,data} = await pinNotesService(id);
+        if (status===200) {
+            // getNotes();
+            setNotes((prev) =>
+                prev?.map((note) =>
+                    note?._id === data?._id ? data : note
+                )
+            )
             toast({
-                description: `Note ${response?.data?.isPinned ? 'pinned' : 'unpinned'} Successfully!`,
+                description: `Note ${data?.isPinned ? 'pinned' : 'unpinned'} Successfully!`,
             });
         } else {
             toast({
diff --git a/client/src/context/TaskProvider.jsx b/client/src/context/TaskProvider.jsx
@@ -12,10 +12,10 @@ export const TaskProvider = ({ children }) => {
     const {searchText} = usePage();
 
     const getTasks = async (query = searchText) => {
-        const response = await fetchTasksService(query);
+        const {status,data} = await fetchTasksService(query);
 
-        if (response?.status === 200) {
-            setTasks(response?.data);
+        if (status === 200) {
+            setTasks(data);
         } else {
             toast({
                 variant: "destructive",
@@ -27,9 +27,9 @@ export const TaskProvider = ({ children }) => {
     }
 
     const addTask = async (noteData) => {
-        const response = await addTaskService(noteData)
-        if (response.status === 201) {
-            getTasks();
+        const {status,data} = await addTaskService(noteData)
+        if (status === 201) {
+            setTasks((prev) => [...prev, data])
             toast({
                 description: "Task added successfully!",
             });
@@ -44,9 +44,13 @@ export const TaskProvider = ({ children }) => {
 
     const editTask = async (id, taskData) => {
 
-        const response = await updateTaskService(id, taskData);
-        if (response?.data) {            
-            getTasks();
+        const {status,data} = await updateTaskService(id, taskData);
+        if (status===200) {            
+            setTasks((prev) =>
+                prev?.map((task) =>
+                    task?._id === data?._id ? data : task
+                )
+            )
             toast({
                 description: "Task edited Successfully!!",
             });
@@ -60,11 +64,15 @@ export const TaskProvider = ({ children }) => {
     }
 
     const pinTask = async (id,isPinned) => {
-        const response = await updateTaskService(id, { isPinned: !isPinned });
-        if (response?.data) {
-            getTasks();
+        const {status,data} = await updateTaskService(id, { isPinned: !isPinned });
+        if (status===200) {
+            setTasks((prev) =>
+                prev?.map((task) =>
+                    task?._id === data?._id ? data : task
+                )
+            )
             toast({
-                description: `Task ${response?.data?.isPinned ? 'pinned' : 'unpinned'} Successfully!`,
+                description: `Task ${data?.isPinned ? 'pinned' : 'unpinned'} Successfully!`,
             });
 
         } else {
@@ -76,13 +84,17 @@ export const TaskProvider = ({ children }) => {
         }
     }
 
-    const checkTask = async (id,status) => {
+    const checkTask = async (task) => {
 
-        const response = await updateTaskService(id, { status: !status });
-        if (response?.data) {
-            getTasks();
+        const {status,data} = await updateTaskService(task?._id, { status: !task?.status });
+        if (status===200) {
+            setTasks((prev) =>
+                prev?.map((task) =>
+                    task?._id === data?._id ? data : task
+                )
+            )
             toast({
-                description: `Task marked as ${response?.data?.status ? 'done' : 'pending'} Successfully!`,
+                description: `Task marked as ${data?.status ? 'done' : 'pending'} Successfully!`,
             });
 
         } else {
@@ -95,9 +107,9 @@ export const TaskProvider = ({ children }) => {
     }
 
     const removeTask = async (id) => {
-        const response = await removeTaskService(id);
-        if (response?.data) {
-            getTasks();
+        const {status,data} = await removeTaskService(id);
+        if (status===200) {
+            setTasks((prevTasks) => prevTasks.filter((task) => task._id !== id));
             toast({
                 description: "Task removed Successfully!",
             });
diff --git a/server/controllers/noteController.js b/server/controllers/noteController.js
@@ -87,7 +87,7 @@ const updateNotes = async (req, res) => {
         await note.save();
 
         // Send the updated note as a response
-        res.json(note);
+        res.status(200).json(note);
     } catch (error) {
         console.error('Error updating note:', error.message);
         res.status(500).json({ msg: 'Internal Server error' }); // 500 Internal Server Error
@@ -117,7 +117,7 @@ const updateNotesIsPinned = async (req, res) => {
         await note.save();
 
         // Send the updated note as a response
-        res.json(note);
+        res.status(200).json(note);
     } catch (error) {
         console.error('Error updating note:', error.message);
         res.status(500).json({ msg: 'Internal Server error' }); // 500 Internal Server Error
@@ -143,7 +143,7 @@ const deleteNotes = async (req, res) => {
         await Note.findByIdAndDelete(id);
 
         // Send a success message after deleting the note
-        res.json({ msg: 'Note deleted' });
+        res.status(200).json({ msg: 'Note deleted' });
     } catch (error) {
         console.error('Error deleting note:', error.message);
         res.status(500).json({ msg: 'Internal Server error' }); // 500 Internal Server Error
diff --git a/server/controllers/taskController.js b/server/controllers/taskController.js
@@ -80,7 +80,7 @@ const updateTask = async (req, res) => {
         await task.save();
 
         // Send the updated task as a response
-        res.json(task);
+        res.status(200).json(task);
     } catch (error) {
         console.error('Error updating task:', error.message);
         res.status(500).json({ msg: 'Internal Server error' }); // 500 Internal Server Error
@@ -106,7 +106,7 @@ const deleteTask = async (req, res) => {
         await Task.findByIdAndDelete(id);
 
         // Send a success message after deleting the task
-        res.json({ msg: 'Task deleted' });
+        res.status(200).json({ msg: 'Task deleted' });
     } catch (error) {
         console.error('Error deleting task:', error.message);
         res.status(500).json({ msg: 'Internal Server error' }); // 500 Internal Server Error

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ const AddEditModal = ({tab, isDialogOpen, setIsDialogOpen, data, type = 'add', o`
`35`	`35`	`if (data?._id === undefined) {`
`36`	`36`	`await onSave(noteData);`
`37`	`37`	`} else {`
`38`		`- await onSave(data?._id, noteData);`
	`38`	`+ await onSave(data, noteData);`
`39`	`39`	`}`
`40`	`40`	`};`
`41`	`41`
Original file line number	Diff line number	Diff line change
`@@ -29,10 +29,10 @@ const DetailModal = ({ sidebarItem = false, data, isDialogOpen, setIsDialogOpen,`
`29`	`29`
`30`	`30`	`const handleStatusClick = () => {`
`31`	`31`	`if (sidebarItem) {`
`32`		`- handleStatus(data?._id, data?.status)`
	`32`	`+ handleStatus(data)`
`33`	`33`	`setIsDialogOpen(false)`
`34`	`34`	`} else {`
`35`		`- handleStatus(data?._id, data?.status)`
	`35`	`+ handleStatus(data)`
`36`	`36`	`}`
`37`	`37`	`}`
`38`	`38`
Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ const TaskLists = ({`
`34`	`34`	`</TableCell>`
`35`	`35`	`<TableCell`
`36`	`36`	`className="[&:has([role=checkbox])]:pr-2 w-[70px] select-none"`
`37`		`- onClick={() => taskOperations?.status(task?._id, task?.status)}`
	`37`	`+ onClick={() => taskOperations?.status(task)}`
`38`	`38`	`>`
`39`	`39`	<div className={`flex items-center justify-end ${task.status ? 'text-green-500' : 'text-yellow-700'}`}>
`40`	`40`	`{task.status ? 'done' : 'pending'}`