-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Open
Labels
Area: ToolingIncludes anything related to Go builds, modules etc and includes Releases & Github Workflows.Includes anything related to Go builds, modules etc and includes Releases & Github Workflows.Type: FeatureNew features or improvements in behaviorNew features or improvements in behavior
Description
Today when the dependency checker fails, meaning a new dependency appeared in an exported package, it shows a red X in the PR, but the checker itself is marked as optional, meaning the PR can be merged.
This relies on a human process that happens to notice the red X and investigates.
Proposal:
- Make the dependency checker a mandatory check.
- Create a new github label, e.g. "Dependency Changes Verified" or something similar.
- Make the dependency checker consider its status green if the label appears.
We still need to solve the problem of:
- PR is created with minor dep change.
- Label is added.
- PR is updated to add a major dep change that we don't want.
So this proposal is still incomplete.
Metadata
Metadata
Assignees
Labels
Area: ToolingIncludes anything related to Go builds, modules etc and includes Releases & Github Workflows.Includes anything related to Go builds, modules etc and includes Releases & Github Workflows.Type: FeatureNew features or improvements in behaviorNew features or improvements in behavior