-
Notifications
You must be signed in to change notification settings - Fork 4.6k
xds/resolver: Optimize Interceptor Chain Construction #8641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xds/resolver: Optimize Interceptor Chain Construction #8641
Conversation
…tor, not for every RPC
|
@eshitachandwani : FYI this might conflict with your resolver changes for A74. And since you have been looking at the resolver code for sometime now, it would be a good PR to review. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8641 +/- ##
==========================================
+ Coverage 79.45% 83.09% +3.64%
==========================================
Files 415 415
Lines 41339 32144 -9195
==========================================
- Hits 32844 26710 -6134
+ Misses 6621 4021 -2600
+ Partials 1874 1413 -461
🚀 New features to boost your workflow:
|
|
@arjan-bal could you review this change, please? |
arjan-bal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving my comments on the non-test code, still reviewing the tests.
|
@arjan-bal : Gentle ping on this one. This is blocking a design change that I need to make to support A83. |
arjan-bal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Existing behavior:
New behavior:
Other changes:
RELEASE NOTES: NONE