Skip to content

Commit 0b5ec44

Browse files
authored
HCK-11191: Remove logging of system info (#32)
<!--do not remove this marker, its needed to replace info when ticket title is updated --> <!--jira-description-action-hidden-marker-start--> <table> <td> <a href="https://hackolade.atlassian.net/browse/HCK-11191" title="HCK-11191" target="_blank"><img alt="Sub-task" src="https://hackolade.atlassian.net/rest/api/2/universal_avatar/view/type/issuetype/avatar/10316?size=medium" />HCK-11191</a> Implement backward compatible solution (wait for tech design) </td></table> <br /> <!--jira-description-action-hidden-marker-end--> ## Content Remove redundant logging of system info
1 parent 5439df4 commit 0b5ec44

File tree

3 files changed

+2
-52
lines changed

3 files changed

+2
-52
lines changed

forward_engineering/helpers/applyToInstanceHelper.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
const vm = require('vm');
22
const bson = require('bson');
33
const connectionHelper = require('../../shared/mongoDbClient');
4-
const { createLogger, getSystemInfo } = require('../../shared/logHelper');
4+
const { createLogger } = require('../../shared/logHelper');
55
const readNdJsonByLine = require('./ndJsonHelper');
66
const { getError } = require('../../shared/getError');
77

@@ -16,7 +16,6 @@ const applyToInstanceHelper = {
1616

1717
try {
1818
logger.clear();
19-
log.info(getSystemInfo(data.appVersion));
2019
log.info(data);
2120

2221
const connection = await connectionHelper.connect(data, sshService);
@@ -53,7 +52,6 @@ const applyToInstanceHelper = {
5352

5453
try {
5554
logger.clear();
56-
log.info(getSystemInfo(connectionInfo.appVersion));
5755
log.info(connectionInfo, 'connectionInfo');
5856

5957
await connectionHelper.connect(connectionInfo, sshService);

reverse_engineering/api.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
const async = require('async');
22
const bson = require('bson');
33
const connectionHelper = require('../shared/mongoDbClient');
4-
const { createLogger, getSystemInfo } = require('../shared/logHelper');
4+
const { createLogger } = require('../shared/logHelper');
55
const { getDocDbClientInstance } = require('../shared/getDocDbClientInstance');
66

77
module.exports = {
@@ -21,7 +21,6 @@ module.exports = {
2121

2222
try {
2323
logger.clear();
24-
log.info(getSystemInfo(connectionInfo.appVersion));
2524
log.info(connectionInfo, 'connectionInfo');
2625

2726
await connectionHelper.connect(connectionInfo, sshService);
@@ -48,7 +47,6 @@ module.exports = {
4847

4948
try {
5049
logger.clear();
51-
log.info(getSystemInfo(connectionInfo.appVersion));
5250
log.info(connectionInfo, 'connectionInfo');
5351

5452
const docDbClientInstance = await getDocDbClientInstance({

shared/logHelper.js

Lines changed: 0 additions & 46 deletions
Original file line numberDiff line numberDiff line change
@@ -1,48 +1,3 @@
1-
const os = require('os');
2-
const packageFile = require('../package.json');
3-
4-
const getPluginVersion = () => packageFile.version;
5-
6-
const getSystemInfo = appVersion => {
7-
return (
8-
'' +
9-
`Date: ${new Date()}` +
10-
'\n' +
11-
`Application version: ${appVersion}` +
12-
'\n' +
13-
`Plugin version: ${getPluginVersion()}` +
14-
'\n\n' +
15-
`System information:` +
16-
'\n' +
17-
` Hostname: ${os.hostname()}` +
18-
'\n' +
19-
` Platform: ${os.platform()} ${os.arch()}` +
20-
'\n' +
21-
` Release: ${os.release()}` +
22-
'\n' +
23-
` Uptime: ${toTime(os.uptime())}` +
24-
'\n' +
25-
` Total RAM: ${(os.totalmem() / 1073741824).toFixed(2)} GB` +
26-
'\n' +
27-
` CPU Model: ${os.cpus()[0].model}` +
28-
'\n' +
29-
` CPU Clock: ${maxClock(os.cpus())} MHZ` +
30-
'\n' +
31-
` CPU Cores: ${os.cpus().length} cores` +
32-
'\n\n'
33-
);
34-
};
35-
36-
const maxClock = cpus => {
37-
return cpus.reduce((highestClock, cpu) => Math.max(highestClock, cpu.speed), 0);
38-
};
39-
40-
const prefixZero = number => (number < 10 ? '0' + number : number);
41-
42-
const toTime = number => {
43-
return Math.floor(number / 3600) + ':' + prefixZero(parseInt((number / 3600 - Math.floor(number / 3600)) * 60));
44-
};
45-
461
const createLogger = ({ title, logger, hiddenKeys }) => {
472
return {
483
info(message, infoTitle) {
@@ -71,5 +26,4 @@ const createError = error => {
7126

7227
module.exports = {
7328
createLogger,
74-
getSystemInfo,
7529
};

0 commit comments

Comments
 (0)