Skip to content
This repository was archived by the owner on Mar 19, 2024. It is now read-only.

Commit 55d507c

Browse files
committed
Fix no matches bug, add route test
1 parent fddb447 commit 55d507c

File tree

3 files changed

+9
-2
lines changed

3 files changed

+9
-2
lines changed

.ignore

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
/vendor/
2+
*cache
3+
routes.js

src/assets/js/routeFunction.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,13 @@ const route = (routeName, params = []) => {
44

55
var uri = _route.uri;
66

7-
const matches = uri.match(/{[\w]+}/g);
7+
const matches = uri.match(/{[\w]+}/g) || [];
88
const requiredParametersCount = matches.length;
99

1010
if (params instanceof Array) {
1111
if (params.length < requiredParametersCount) throw "Missing parameters";
1212

13-
for (var i = 0; i < matches.length; i++)
13+
for (var i = 0; i < requiredParametersCount; i++)
1414
uri = uri.replace(/{[\w]+}/, params.shift());
1515

1616
for (var i = 0; i < params.length; i++)

tests/CreateJSRoutesCommandTest.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,10 @@ protected function getPackageProviders($app)
1616

1717
protected function getEnvironmentSetUp($app)
1818
{
19+
$app['router']->get('get', ['as' => 'get', 'uses' => function () {
20+
return 'hello world';
21+
}]);
22+
1923
$app['router']->get('get/{id}', ['as' => 'hi', 'uses' => function () {
2024
return 'hello world';
2125
}]);

0 commit comments

Comments
 (0)