Skip to content

Add plot_annotation for compositions #1002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
has2k1 wants to merge 24 commits into
base: main
Choose a base branch
from
Open

Add plot_annotation for compositions #1002

has2k1 wants to merge 24 commits into from

Conversation

@has2k1
Copy link
Owner

@has2k1 has2k1 commented Oct 28, 2025

closes #966

@has2k1 has2k1 mentioned this pull request Oct 28, 2025
Open
@codecov
Copy link

codecov bot commented Oct 29, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 91.71123% with 62 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.75%. Comparing base (0da5f04) to head (320d52d).

Files with missing lines Patch % Lines
...ine/_mpl/layout_manager/_composition_side_space.py 89.10% 22 Missing ⚠️
plotnine/_mpl/layout_manager/_layout_tree.py 77.77% 14 Missing ⚠️
plotnine/_mpl/utils.py 89.28% 8 Missing and 1 partial ⚠️
plotnine/composition/_compose.py 93.87% 4 Missing and 2 partials ⚠️
...e/_mpl/layout_manager/_composition_layout_items.py 90.69% 2 Missing and 2 partials ⚠️
plotnine/_mpl/layout_manager/_side_space.py 92.68% 2 Missing and 1 partial ⚠️
plotnine/_mpl/layout_manager/_plot_side_space.py 97.75% 2 Missing ⚠️
plotnine/composition/_plot_annotation.py 93.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1002      +/-   ##
==========================================
+ Coverage   86.73%   86.75%   +0.01%     
==========================================
  Files         198      202       +4     
  Lines       13246    13596     +350     
  Branches     1653     1678      +25     
==========================================
+ Hits        11489    11795     +306     
- Misses       1208     1251      +43     
- Partials      549      550       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

has2k1 added 24 commits November 17, 2025 15:54
@has2k1
Add plot_annotation class
65ef6d2
@has2k1
Rename helper class Calc to ArtistGeometry
3acb97c
@has2k1
Refactor the setup of compositions and themes
24a6f13
@has2k1
Rename facet._panels_gridspec to _gridspec
e93dc6d
@has2k1
Rename _*_spaces to _*_space
c1efcd5
@has2k1
Refactor _side_space to introduce _plot_side_space
2b951fd
@has2k1
Refactor to use CompositionItems
1d11c39 
This allows us to associate gridspecs more consistently, where the a
plots and compositions can both a "container" 1x1 gridspec. So that
composition items are to a composition what facets(panels) are to a
plot.
@has2k1
Make TextJustifier independent of the Spaces
3d8752e
@has2k1
Rename LayoutSpaces to PlotLayoutSpaces
b2b41e3 
This change is in preparation for an similar function that will work for
compositions.
@has2k1
Apply theme to the plot composition
c3be061
@has2k1
Make compose.theme combine default theme with annotation theme
2bd79de
@has2k1
Don't use dataclasses for _side_space
e27e502
@has2k1
Don't use a dataclass for PlotLayoutItems
4e78597
@has2k1
Compute side_space for the compositions
d3576c6 
The plot_composition test images have changed because the compositions
now have a plot margin.
@has2k1
Draw sub-compositions recursively
c54ff2f
@has2k1
Use gridspec & sub_gridspec for well defined roles
f732b49
@has2k1
Rename *LayoutSpaces to *SideSpaces
97872fe
@has2k1
Use horizontal/vertical_space methods to resize compositions
1d8ae43
@has2k1
Reuse PlotLayoutSpaces panel_width & panel_height
a9f80b4
@has2k1
Add _sidespaces parameters to ggplot & compose
1b32a2b 
We are preparing to accurately resize compositions that have
annotations.
@has2k1
Do not apply annotations of sub_compositions
a662696
@has2k1
Use one layout_engine class for both plots and compositions
5bf4e42
@has2k1
Add plot_annotation tests
464243e
@has2k1
DOC: plot_annotation
320d52d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature request: add plot_annotation to add Titles, subtitles and captions to composite plots

2 participants

@has2k1