updated cleanup code

Author: zamoore

packages/components/src/components/hds/advanced-table/index.ts

@@ -615,6 +615,7 @@ export default class HdsAdvancedTable extends Component<HdsAdvancedTableSignatur
 
   @action
   setupTableModelData(): void {
+    console.log('setting up table model data');
     const { columns, model, sortBy, sortOrder } = this.args;
 
     this._tableModel.setupData({
@@ -678,9 +679,20 @@ export default class HdsAdvancedTable extends Component<HdsAdvancedTableSignatur
 
   @action
   willDestroyRowCheckbox(selectionKey?: string): void {
-    this._selectableRows = this._selectableRows.filter(
-      (row) => row.selectionKey !== selectionKey
+    if (selectionKey === undefined) {
+      return;
+    }
+
+    const index = this._selectableRows.findIndex(
+      (row) => row.selectionKey === selectionKey
     );
+
+    if (index === -1) {
+      return;
+    }
+
+    this._selectableRows.splice(index, 1);
+
     this.setSelectAllState();
   }
 

showcase/app/components/page-components/advanced-table/index.gts

@@ -7,30 +7,28 @@ import { pageTitle } from 'ember-page-title';
 
 import ShwTextH1 from 'showcase/components/shw/text/h1';
 
-import SubSectionTest from 'showcase/components/page-components/advanced-table/sub-sections/test';
-// import SubSectionBaseElements from 'showcase/components/page-components/advanced-table/sub-sections/base-elements';
-// import SubSectionBasic from 'showcase/components/page-components/advanced-table/sub-sections/basic';
-// import SubSectionCustomization from 'showcase/components/page-components/advanced-table/sub-sections/customization';
-// import SubSectionDemos from 'showcase/components/page-components/advanced-table/sub-sections/demos';
-// import SubSectionFunctionalExamples from 'showcase/components/page-components/advanced-table/sub-sections/functional-examples';
-// import SubSectionLayout from 'showcase/components/page-components/advanced-table/sub-sections/layout';
-// import SubSectionMultiSelect from 'showcase/components/page-components/advanced-table/sub-sections/multi-select';
-// import SubSectionNestedRows from 'showcase/components/page-components/advanced-table/sub-sections/nested-rows';
-// import SubSectionOverflow from 'showcase/components/page-components/advanced-table/sub-sections/overflow';
-// import SubSectionPinnableColumns from 'showcase/components/page-components/advanced-table/sub-sections/pinnable-column';
-// import SubSectionReorderableColumns from 'showcase/components/page-components/advanced-table/sub-sections/reorderable-columns';
-// import SubSectionResizableColumns from 'showcase/components/page-components/advanced-table/sub-sections/resizable-columns';
-// import SubSectionSorting from 'showcase/components/page-components/advanced-table/sub-sections/sorting';
-// import SubSectionTooltip from 'showcase/components/page-components/advanced-table/sub-sections/tooltip';
+import SubSectionBaseElements from 'showcase/components/page-components/advanced-table/sub-sections/base-elements';
+import SubSectionBasic from 'showcase/components/page-components/advanced-table/sub-sections/basic';
+import SubSectionCustomization from 'showcase/components/page-components/advanced-table/sub-sections/customization';
+import SubSectionDemos from 'showcase/components/page-components/advanced-table/sub-sections/demos';
+import SubSectionFunctionalExamples from 'showcase/components/page-components/advanced-table/sub-sections/functional-examples';
+import SubSectionLayout from 'showcase/components/page-components/advanced-table/sub-sections/layout';
+import SubSectionMultiSelect from 'showcase/components/page-components/advanced-table/sub-sections/multi-select';
+import SubSectionNestedRows from 'showcase/components/page-components/advanced-table/sub-sections/nested-rows';
+import SubSectionOverflow from 'showcase/components/page-components/advanced-table/sub-sections/overflow';
+import SubSectionPinnableColumns from 'showcase/components/page-components/advanced-table/sub-sections/pinnable-column';
+import SubSectionReorderableColumns from 'showcase/components/page-components/advanced-table/sub-sections/reorderable-columns';
+import SubSectionResizableColumns from 'showcase/components/page-components/advanced-table/sub-sections/resizable-columns';
+import SubSectionSorting from 'showcase/components/page-components/advanced-table/sub-sections/sorting';
+import SubSectionTooltip from 'showcase/components/page-components/advanced-table/sub-sections/tooltip';
 
 const AdvancedTableIndex: TemplateOnlyComponent = <template>
   {{pageTitle "AdvancedTable Component"}}
 
   <ShwTextH1>AdvancedTable</ShwTextH1>
 
   <section data-test-percy>
-    <SubSectionTest />
-    {{! <SubSectionBasic />
+    <SubSectionBasic />
     <SubSectionNestedRows />
     <SubSectionOverflow />
     <SubSectionSorting />
@@ -43,7 +41,7 @@ const AdvancedTableIndex: TemplateOnlyComponent = <template>
     <SubSectionCustomization />
     <SubSectionLayout />
     <SubSectionDemos />
-    <SubSectionBaseElements /> }}
+    <SubSectionBaseElements />
   </section>
 </template>;