Skip to content

Commit e128d96

Browse files
committed
add missing {{on "change" this.onChange}} handled to the RadioCard elements when in a group
1 parent 8f4f7d4 commit e128d96

File tree

1 file changed

+36
-10
lines changed
  • showcase/app/components/page-carbonization/components/form/radio-card

1 file changed

+36
-10
lines changed

showcase/app/components/page-carbonization/components/form/radio-card/index.gts

Lines changed: 36 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import type { TemplateOnlyComponent } from '@ember/component/template-only';
88
import { pageTitle } from 'ember-page-title';
99
import { capitalize } from '@ember/string';
1010
import { eq } from 'ember-truth-helpers';
11+
import { on } from '@ember/modifier';
1112

1213
import ShwTextH1 from 'showcase/components/shw/text/h1';
1314
import ShwTextH2 from 'showcase/components/shw/text/h2';
@@ -164,13 +165,18 @@ export default class FormRadioCardCarbonizationIndex extends Component {
164165
as |G|
165166
>
166167
<G.Legend>This is the group legend</G.Legend>
167-
<G.RadioCard @checked={{true}} @value="1" as |R|>
168+
<G.RadioCard
169+
@checked={{true}}
170+
@value="1"
171+
{{on "change" this.onChange}}
172+
as |R|
173+
>
168174
<R.Icon @name="hexagon" />
169175
<R.Label>Radio card label 1</R.Label>
170176
<R.Badge @text="Badge" />
171177
<R.Description>Radio card description 1</R.Description>
172178
</G.RadioCard>
173-
<G.RadioCard @value="2" as |R|>
179+
<G.RadioCard @value="2" {{on "change" this.onChange}} as |R|>
174180
<R.Icon @name="hexagon" />
175181
<R.Label>Radio card label 2</R.Label>
176182
<R.Badge @text="Badge" />
@@ -213,13 +219,18 @@ export default class FormRadioCardCarbonizationIndex extends Component {
213219
>
214220
<G.Legend>This is the group legend</G.Legend>
215221
<G.HelperText>This is the group helper text</G.HelperText>
216-
<G.RadioCard @checked={{true}} @value="1" as |R|>
222+
<G.RadioCard
223+
@checked={{true}}
224+
@value="1"
225+
{{on "change" this.onChange}}
226+
as |R|
227+
>
217228
<R.Icon @name="hexagon" />
218229
<R.Label>Radio card label 1</R.Label>
219230
<R.Badge @text="Badge" />
220231
<R.Description>Radio card description 1</R.Description>
221232
</G.RadioCard>
222-
<G.RadioCard @value="2" as |R|>
233+
<G.RadioCard @value="2" {{on "change" this.onChange}} as |R|>
223234
<R.Icon @name="hexagon" />
224235
<R.Label>Radio card label 2</R.Label>
225236
<R.Badge @text="Badge" />
@@ -266,13 +277,18 @@ export default class FormRadioCardCarbonizationIndex extends Component {
266277
@controlPosition={{position}}
267278
as |G|
268279
>
269-
<G.RadioCard @checked={{true}} @value="1" as |R|>
280+
<G.RadioCard
281+
@checked={{true}}
282+
@value="1"
283+
{{on "change" this.onChange}}
284+
as |R|
285+
>
270286
<R.Icon @name="hexagon" />
271287
<R.Label>Radio card label 1</R.Label>
272288
<R.Badge @text="Badge" />
273289
<R.Description>Radio card description 1</R.Description>
274290
</G.RadioCard>
275-
<G.RadioCard @value="2" as |R|>
291+
<G.RadioCard @value="2" {{on "change" this.onChange}} as |R|>
276292
<R.Icon @name="hexagon" />
277293
<R.Label>Radio card label 2</R.Label>
278294
<R.Badge @text="Badge" />
@@ -318,13 +334,18 @@ export default class FormRadioCardCarbonizationIndex extends Component {
318334
@alignment={{alignment}}
319335
as |G|
320336
>
321-
<G.RadioCard @checked={{true}} @value="1" as |R|>
337+
<G.RadioCard
338+
@checked={{true}}
339+
@value="1"
340+
{{on "change" this.onChange}}
341+
as |R|
342+
>
322343
<R.Icon @name="hexagon" />
323344
<R.Label>Radio card label 1</R.Label>
324345
<R.Badge @text="Badge" />
325346
<R.Description>Radio card description 1</R.Description>
326347
</G.RadioCard>
327-
<G.RadioCard @value="2" as |R|>
348+
<G.RadioCard @value="2" {{on "change" this.onChange}} as |R|>
328349
<R.Icon @name="hexagon" />
329350
<R.Label>Radio card label 2</R.Label>
330351
<R.Badge @text="Badge" />
@@ -373,13 +394,18 @@ export default class FormRadioCardCarbonizationIndex extends Component {
373394
@layout={{layout}}
374395
as |G|
375396
>
376-
<G.RadioCard @checked={{true}} @value="1" as |R|>
397+
<G.RadioCard
398+
@checked={{true}}
399+
@value="1"
400+
{{on "change" this.onChange}}
401+
as |R|
402+
>
377403
<R.Icon @name="hexagon" />
378404
<R.Label>Radio card label 1</R.Label>
379405
<R.Badge @text="Badge" />
380406
<R.Description>Radio card description 1</R.Description>
381407
</G.RadioCard>
382-
<G.RadioCard @value="2" as |R|>
408+
<G.RadioCard @value="2" {{on "change" this.onChange}} as |R|>
383409
<R.Icon @name="hexagon" />
384410
<R.Label>Radio card label 2</R.Label>
385411
<R.Badge @text="Badge" />

0 commit comments

Comments
 (0)