iterate over all modules and break out early if possible

Author: dsa0x

internal/configs/config.go

@@ -5,6 +5,7 @@ package configs
 
 import (
 	"fmt"
+	"iter"
 	"log"
 	"maps"
 	"slices"
@@ -143,15 +144,16 @@ func (c *Config) DeepEach(cb func(c *Config)) {
 	}
 }
 
-// AllModules returns a slice of all the receiver and all of its descendant
-// nodes in the module tree, in the same order they would be visited by
-// DeepEach.
-func (c *Config) AllModules() []*Config {
-	var ret []*Config
-	c.DeepEach(func(c *Config) {
-		ret = append(ret, c)
-	})
-	return ret
+// AllModules returns an iterator of all the receiver and all of its descendant
+// nodes in the module tree until the iterator is exhausted or terminated.
+func (c *Config) AllModules() iter.Seq[*Config] {
+	return func(yield func(*Config) bool) {
+		for _, ch := range c.Children {
+			if !yield(ch) {
+				return
+			}
+		}
+	}
 }
 
 // Descendant returns the descendant config that has the given path beneath

internal/terraform/context_plan.go

@@ -272,11 +272,12 @@ The -target option is not for routine use, and is provided only for exceptional
 
 	if opts.Query {
 		var hasQuery bool
-		config.DeepEach(func(c *configs.Config) {
+		for c := range config.AllModules() {
 			if len(c.Module.ListResources) > 0 {
 				hasQuery = true
+				break
 			}
-		})
+		}
 
 		if !hasQuery {
 			diags = diags.Append(tfdiags.Sourceless(