Skip to content

Commit c1cd0c1

Browse files
Update SDK (#813)
<!-- The PR description should answer 2 (maybe 3) important questions: --> ### What Update to `ndc-sdk-rs` `0.8.0` so we output connector name and version in traces.
1 parent acd0838 commit c1cd0c1

File tree

4 files changed

+72
-5
lines changed

4 files changed

+72
-5
lines changed

Cargo.lock

Lines changed: 61 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ too_many_lines = "allow"
3232

3333
[workspace.dependencies]
3434
ndc-models = { git = "https://github.com/hasura/ndc-spec.git", tag = "v0.2.4" }
35-
ndc-sdk = { git = "https://github.com/hasura/ndc-sdk-rs.git", rev = "v0.7.0" }
35+
ndc-sdk = { git = "https://github.com/hasura/ndc-sdk-rs.git", rev = "v0.8.0" }
3636
ndc-test = { git = "https://github.com/hasura/ndc-spec.git", tag = "v0.2.3" }
3737

3838
anyhow = "1"

changelog.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@
66

77
### Changed
88

9+
- Bump `ndc-sdk-rs` to `0.8.0` to start outputting connector name and version in traces.
10+
911
### Fixed
1012

1113
- Fix a bug where the configuration jsonschema for `DynamicConnectionSettings` was not correctly renaming fields to camelCase.

crates/connectors/ndc-postgres/src/connector.rs

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,14 @@ impl Connector for Postgres {
3131
/// The unserializable, transient state
3232
type State = Arc<state::State>;
3333

34+
fn connector_name() -> &'static str {
35+
"ndc_postgres"
36+
}
37+
38+
fn connector_version() -> &'static str {
39+
env!("CARGO_PKG_VERSION")
40+
}
41+
3442
/// Update any metrics from the state
3543
///
3644
/// Note: some metrics can be updated directly, and do not

0 commit comments

Comments
 (0)