Skip to content

Commit ef8f568

Browse files
authored
Fix codecov-action [DI-520] (#1536)
The C++ coverage action has been [silently failing](https://github.com/hazelcast/hazelcast-cpp-client/actions/runs/15610247637/attempts/1). Updated all usages to: - supply a token to properly authenticate (the reason for the failure) - fail the step if the upload fails (to avoid the error going unreported) - use the latest version (consistency) Fixes: [DI-520](https://hazelcast.atlassian.net/browse/DI-520) [DI-520]: https://hazelcast.atlassian.net/browse/DI-520?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
1 parent 73250c1 commit ef8f568

File tree

1 file changed

+9
-3
lines changed

1 file changed

+9
-3
lines changed

.github/workflows/coverage_runner.yml

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -97,23 +97,29 @@ jobs:
9797
9898
- name: Publish results to Codecov for PR coming from hazelcast organization
9999
if: ${{ matrix.os == 'ubuntu-latest' && github.event_name == 'pull_request_target' }}
100-
uses: codecov/codecov-action@v3
100+
uses: codecov/codecov-action@v5
101101
with:
102+
token: ${{ secrets.CODECOV_TOKEN }}
102103
files: coverage/lcov.info
103104
override_pr: ${{ github.event.pull_request.number }}
105+
fail_ci_if_error: true
104106

105107
- name: Publish results to Codecov for Push
106108
if: ${{ matrix.os == 'ubuntu-latest' && github.event_name == 'push' }}
107-
uses: codecov/codecov-action@v3
109+
uses: codecov/codecov-action@v5
108110
with:
111+
token: ${{ secrets.CODECOV_TOKEN }}
109112
files: coverage/lcov.info
113+
fail_ci_if_error: true
110114

111115
- name: Publish result to Codecov for PR coming from community
112116
if: ${{ matrix.os == 'ubuntu-latest' && github.event_name == 'workflow_dispatch' }}
113-
uses: codecov/codecov-action@v3
117+
uses: codecov/codecov-action@v5
114118
with:
119+
token: ${{ secrets.CODECOV_TOKEN }}
115120
files: coverage/lcov.info
116121
override_pr: ${{ github.event.inputs.pr_number }}
122+
fail_ci_if_error: true
117123

118124
- name: Upload remote controller logs if test run fails
119125
uses: actions/upload-artifact@v4

0 commit comments

Comments
 (0)