Skip to content

Commit eb0e825

Browse files
committed
style(uhyve): fix some random clippy errors, add todo
1 parent fefab1b commit eb0e825

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

src/fs/uhyve.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ use uhyve_interface::v2::Hypercall;
1313
use uhyve_interface::v2::parameters::{
1414
CloseParams, LseekParams, OpenParams, ReadParams, UnlinkParams, WriteParams,
1515
};
16-
use uhyve_interface::{GuestPhysAddr, GuestVirtAddr};
16+
use uhyve_interface::GuestPhysAddr;
1717

1818
use crate::arch::mm::paging;
1919
use crate::env::fdt;

src/syscalls/interfaces/uhyve.rs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
use core::ptr;
22

3-
use memory_addresses::{PhysAddr, VirtAddr};
3+
use memory_addresses::VirtAddr;
44
use uhyve_interface::v2::parameters::{ExitParams, SerialWriteBufferParams};
55
use uhyve_interface::v2::{Hypercall, HypercallAddress};
66

@@ -48,7 +48,7 @@ fn hypercall_data(hypercall: &Hypercall<'_>) -> u64 {
4848
#[inline]
4949
#[allow(unused_variables)] // until riscv64 is implemented
5050
pub(crate) fn uhyve_hypercall(hypercall: Hypercall<'_>) {
51-
let mut ptr = HypercallAddress::from(&hypercall) as u64;
51+
let ptr = HypercallAddress::from(&hypercall) as u64;
5252
let data = hypercall_data(&hypercall);
5353

5454
#[cfg(target_arch = "x86_64")]
@@ -76,6 +76,7 @@ pub struct Uhyve;
7676

7777
impl SyscallInterface for Uhyve {
7878
fn shutdown(&self, error_code: i32) -> ! {
79+
// FIXME: fix negative integers
7980
let sysexit = ExitParams { arg: error_code };
8081
uhyve_hypercall(Hypercall::Exit(error_code));
8182

0 commit comments

Comments
 (0)