Skip to content

Commit e320ecd

Browse files
BGNutbeikov
authored andcommitted
HHH-19651: Make the DB2i detection more reliable
1 parent c29bd4a commit e320ecd

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

hibernate-core/src/main/java/org/hibernate/dialect/Database.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,11 +42,15 @@ public Dialect createDialect(DialectResolutionInfo info) {
4242
return new DB2zDialect( info );
4343
}
4444
case "QSQ": {
45-
// i
45+
// i, this only works if "use drda metadata version" property is set to true in the drivers properties
4646
return new DB2iDialect( info );
4747
}
4848
}
4949
}
50+
if ("DB2 UDB for AS/400".equals(info.getDatabaseName())) {
51+
// i
52+
return new DB2iDialect( info );
53+
}
5054

5155
return new DB2Dialect( info );
5256
}

hibernate-core/src/test/java/org/hibernate/orm/test/dialect/resolver/DialectFactoryTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -149,8 +149,8 @@ public void testPreregisteredDialects() {
149149
testDetermination( "DB2/SUN", DB2Dialect.class, resolver );
150150
testDetermination( "DB2/LINUX390", DB2Dialect.class, resolver );
151151
testDetermination( "DB2/AIX64", DB2Dialect.class, resolver );
152-
testDetermination( "DB2 UDB for AS/400", DB2Dialect.class, resolver );
153-
testDetermination( "DB2 UDB for AS/400", 7, 3, DB2Dialect.class, resolver );
152+
testDetermination( "DB2 UDB for AS/400", DB2iDialect.class, resolver );
153+
testDetermination( "DB2 UDB for AS/400", 7, 3, DB2iDialect.class, resolver );
154154
testDetermination( "Oracle", 8, OracleDialect.class, resolver );
155155
testDetermination( "Oracle", 9, OracleDialect.class, resolver );
156156
testDetermination( "Oracle", 10, OracleDialect.class, resolver );

0 commit comments

Comments
 (0)