HBX-3249: Refactor class MappingExporter and improve tests #5847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Pull up the MappingBinder passed around to an instance variable Signed-off-by: Koen Aers <koen.aers@gmail.com>
- Inline 'performTransformation' into 'start' - Initialize the 'hbmXmlFiles' instance variable - Remove unneeded parameter 'formatResult' from 'marshall' Signed-off-by: Koen Aers <koen.aers@gmail.com>
- Rename 'getHbmMappings' to 'getHbmBindings' - Rename 'bindMapping' to 'bindHbmXml' - Remove unneeded argument 'mappingBinder' from 'bindHbmXml' - Adapt the related tests to the above changes Signed-off-by: Koen Aers <koen.aers@gmail.com>
- Remove unneeded 'mappingBinder' argument from 'createMarshaller' - Create 'marshaller' instance variable and populate it in the constructor - Remove the 'marshaller' local variable in the 'start' method - Remove the 'marshaller' argument from the 'marshall' method Signed-off-by: Koen Aers <koen.aers@gmail.com>
- Add method 'transformBindings' and add a test method for it - Complete the 'start' method to perform the transformation logic - Enable 'testStart' and complete the test method Signed-off-by: Koen Aers <koen.aers@gmail.com>
- Collapse HbmXmlOrigin as an inner class into MappingExporter - Move 'testHbmXmlOrigin' to 'MappingExporterTest' - Remove 'HbmXmlOrigin' and 'HbmXmlOriginTest' Signed-off-by: Koen Aers <koen.aers@gmail.com>
|
Thanks for your pull request! This pull request appears to follow the contribution rules. › This message was automatically generated. |
koentsje
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.