fix: adds acceptance test toAddress is null and to field is missing (#4455)

Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
Co-authored-by: Logan Nguyen <logan.nguyen@swirldslabs.com>

Author: konstantinabl

packages/relay/tests/lib/eth/eth_getTransactionByHash.spec.ts

@@ -242,10 +242,7 @@ describe('@ethGetTransactionByHash eth_getTransactionByHash tests', async functi
       .onGet(`contracts/results/${uniqueTxHash}`)
       .reply(200, JSON.stringify(detailedResultsWithNullNullableValues));
     const result = await ethImpl.getTransactionByHash(uniqueTxHash, requestDetails);
-    expect(result).to.not.be.null;
-
-    expect(result).to.exist;
-    if (result) expect(result.gas).to.eq('0x0');
+    expect(result!.gas).to.eq('0x0');
   });
 
   it('handles transactions with null amount', async function () {
@@ -259,10 +256,7 @@ describe('@ethGetTransactionByHash eth_getTransactionByHash tests', async functi
       .onGet(`contracts/results/${uniqueTxHash}`)
       .reply(200, JSON.stringify(detailedResultsWithNullNullableValues));
     const result = await ethImpl.getTransactionByHash(uniqueTxHash, requestDetails);
-    expect(result).to.not.be.null;
-
-    expect(result).to.exist;
-    if (result) expect(result.value).to.eq('0x0');
+    expect(result!.value).to.eq('0x0');
   });
 
   it('handles transactions with v as null', async function () {
@@ -277,10 +271,7 @@ describe('@ethGetTransactionByHash eth_getTransactionByHash tests', async functi
       .onGet(`contracts/results/${uniqueTxHash}`)
       .reply(200, JSON.stringify(detailedResultsWithNullNullableValues));
     const result = await ethImpl.getTransactionByHash(uniqueTxHash, requestDetails);
-    expect(result).to.not.be.null;
-
-    expect(result).to.exist;
-    if (result) expect(result.v).to.eq('0x0');
+    expect(result!.v).to.eq('0x0');
   });
 
   it('should throw an error if transaction_index is falsy', async function () {
@@ -298,7 +289,6 @@ describe('@ethGetTransactionByHash eth_getTransactionByHash tests', async functi
       await ethImpl.getTransactionByHash(uniqueTxHash, requestDetails);
       expect.fail('should have thrown an error');
     } catch (error) {
-      expect(error).to.exist;
       expect(error).to.eq(predefined.DEPENDENT_SERVICE_IMMATURE_RECORDS);
     }
   });
@@ -317,7 +307,6 @@ describe('@ethGetTransactionByHash eth_getTransactionByHash tests', async functi
       await ethImpl.getTransactionByHash(uniqueTxHash, requestDetails);
       expect.fail('should have thrown an error');
     } catch (error) {
-      expect(error).to.exist;
       expect(error).to.eq(predefined.DEPENDENT_SERVICE_IMMATURE_RECORDS);
     }
   });
@@ -338,7 +327,6 @@ describe('@ethGetTransactionByHash eth_getTransactionByHash tests', async functi
       await ethImpl.getTransactionByHash(uniqueTxHash, requestDetails);
       expect.fail('should have thrown an error');
     } catch (error) {
-      expect(error).to.exist;
       expect(error).to.eq(predefined.DEPENDENT_SERVICE_IMMATURE_RECORDS);
     }
   });
@@ -355,4 +343,17 @@ describe('@ethGetTransactionByHash eth_getTransactionByHash tests', async functi
       maxPriorityFeePerGas: '0x43',
     });
   });
+
+  it('returns to field for transaction with contract revert on contract creation', async function () {
+    const detailedResultsWithNullTo = {
+      ...defaultDetailedContractResultByHash,
+      to: null,
+    };
+
+    const uniqueTxHash = '0x15aad7b827375d12d73af57b6a3e84353645fd31305ea58ff52dda53ec640533';
+
+    restMock.onGet(`contracts/results/${uniqueTxHash}`).reply(200, JSON.stringify(detailedResultsWithNullTo));
+    const result = await ethImpl.getTransactionByHash(uniqueTxHash, requestDetails);
+    expect(result?.to).to.eq(null);
+  });
 });

packages/server/tests/acceptance/rpc_batch1.spec.ts

@@ -733,7 +733,7 @@ describe('@api-batch-1 RPC Server Acceptance Tests', function () {
         expect(res).to.be.null;
       });
 
-      it('should execute "eth_getBlockReceipts" for a block that contains synthetic transaction', async function() {
+      it('should execute "eth_getBlockReceipts" for a block that contains synthetic transaction', async function () {
         const tokenId = await servicesNode.createToken(1000);
         await accounts[2].client.associateToken(tokenId);
         const transaction = new TransferTransaction()
@@ -754,7 +754,7 @@ describe('@api-batch-1 RPC Server Acceptance Tests', function () {
 
         const receipts = await relay.call(RelayCalls.ETH_ENDPOINTS.ETH_GET_BLOCK_RECEIPTS, [formattedBlockNumber]);
         expect(receipts).to.not.be.empty;
-        expect(receipts.filter(receipt => receipt.transactionHash === transactionHash)).to.not.be.empty;
+        expect(receipts.filter((receipt) => receipt.transactionHash === transactionHash)).to.not.be.empty;
       });
     });
 
@@ -2019,6 +2019,27 @@ describe('@api-batch-1 RPC Server Acceptance Tests', function () {
         ]);
         expect(res).to.be.null;
       });
+
+      it('@release getTransactionByHash should return null for to for reverted contract creation', async function () {
+        // the data below is actually disassembled opcodes
+        // containing revert as well
+        const dataToRevert = '0x600160015560006000fd';
+        const gasPrice = await relay.gasPrice();
+        const transaction = {
+          ...defaultLondonTransactionData,
+          to: null,
+          data: dataToRevert,
+          nonce: await relay.getAccountNonce(accounts[2].address),
+          maxPriorityFeePerGas: gasPrice,
+          maxFeePerGas: gasPrice,
+        };
+        const signedTx = await accounts[2].wallet.signTransaction(transaction);
+        const transactionHash = await relay.sendRawTransaction(signedTx);
+
+        const res = await relay.call(RelayCalls.ETH_ENDPOINTS.ETH_GET_TRANSACTION_BY_HASH, [transactionHash]);
+
+        expect(res.to).to.be.null;
+      });
     });
   });
 });