Skip to content

Commit 08996b9

Browse files
authored
Merge pull request #83 from highcharts/chore/update-400-text
Updated 400 text and bumped webpack timeout
2 parents 2ce8df1 + 62c874a commit 08996b9

File tree

3 files changed

+4
-5
lines changed

3 files changed

+4
-5
lines changed

app/message.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
},
77
"error": {
88
"status": 400,
9-
"body": "Something went wrong. Please contact <a href=\"http://www.highcharts.com/support\">Highcharts support</a> if this happens repeatedly."
9+
"body": "Something went wrong. Please note that this service is for debugging only. Use our <a href=\"http://code.highcharts.com\">official CDN</a> in production."
1010
},
1111
"missingFile": {
1212
"status": 400,

src/utils.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ function compileWebpack(srcFolder: string, config ='highcharts.webpack.mjs') {
1919

2020
return execAsync(
2121
`npx webpack -c ${join(configDir, config)} --output-path ./output --stats errors-only`,
22-
{ timeout: 7000, cwd: srcFolder }
22+
{ timeout: 7500, cwd: srcFolder }
2323
).then(({stdout, stderr}) => {
2424
if (stderr) {
2525
console.error(stderr);

test/middleware.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -78,9 +78,8 @@ describe('middleware.js', () => {
7878
const next = stub()
7979
clientErrorHandler(new Error('myerror'), req, res, next)
8080
expect(res.status.getCall(0).args[0]).to.equal(400)
81-
expect(res.send.getCall(0).args[0]).to.equal(
82-
'Something went wrong. Please contact <a href="http://www.highcharts.com/support">Highcharts support</a> if this happens repeatedly.'
83-
)
81+
expect(res.send.getCall(0).args[0]).to.contain(
82+
'Something went wrong.')
8483
expect(next.called).to.equal(true)
8584
})
8685
})

0 commit comments

Comments
 (0)