refactor: improve thick rendering implementation with better validation and optimization

Author: ra100

model/line_2d.py

@@ -49,19 +49,32 @@ def is_dashed(self):
         return self.construction
 
     def update(self):
+        """Update the line's visual representation with thick geometry for Vulkan compatibility.
+
+        Creates triangle-based geometry for both solid and dashed lines to ensure
+        consistent visibility across different graphics backends.
+        """
         if bpy.app.background:
             return
 
-        p1, p2 = self.p1.location, self.p2.location
+        try:
+            p1, p2 = self.p1.location, self.p2.location
 
-        if self.is_dashed():
-            coords, indices = draw_thick_dashed_line_3d(p1, p2, self.line_width)
-        else:
-            coords, indices = draw_thick_line_3d(p1, p2, self.line_width)
-        kwargs = {"pos": coords}
-        self._batch = batch_for_shader(self._shader, "TRIS", kwargs, indices=indices)
+            if self.is_dashed():
+                coords, indices = draw_thick_dashed_line_3d(p1, p2, self.line_width)
+            else:
+                coords, indices = draw_thick_line_3d(p1, p2, self.line_width)
+
+            if not coords:
+                logger.warning(f"Failed to create thick line geometry for {self}")
+                return
 
-        self.is_dirty = False
+            kwargs = {"pos": coords}
+            self._batch = batch_for_shader(self._shader, "TRIS", kwargs, indices=indices)
+            self.is_dirty = False
+        except Exception as e:
+            logger.error(f"Error updating line {self}: {e}")
+            self.is_dirty = False
 
     def create_slvs_data(self, solvesys, group=Solver.group_fixed):
         handle = solvesys.addLineSegment(self.p1.py_data, self.p2.py_data, group=group)

model/point_2d.py

@@ -24,14 +24,28 @@ def is_point(cls):
         return True
 
     def update(self):
+        """Update the point's visual representation with thick geometry for Vulkan compatibility.
+
+        Creates a triangle-based quad geometry for better visibility across different
+        graphics backends, especially Vulkan where traditional point rendering may
+        result in barely visible 1px points.
+        """
         if bpy.app.background:
             return
 
-        coords, indices = draw_thick_point_3d(self.location, self.point_size)
-        kwargs = {"pos": coords}
-        self._batch = batch_for_shader(self._shader, "TRIS", kwargs, indices=indices)
-
-        self.is_dirty = False
+        try:
+            coords, indices = draw_thick_point_3d(self.location, self.point_size)
+            if not coords:
+                # Fallback to ensure we have something to render
+                logger.warning(f"Failed to create thick point geometry for {self}")
+                return
+
+            kwargs = {"pos": coords}
+            self._batch = batch_for_shader(self._shader, "TRIS", kwargs, indices=indices)
+            self.is_dirty = False
+        except Exception as e:
+            logger.error(f"Error updating point {self}: {e}")
+            self.is_dirty = False  # Prevent infinite update loops
 
     @property
     def location(self):

model/workplane.py

@@ -10,7 +10,7 @@
 
 from ..declarations import Operators
 from .. import global_data
-from ..utilities.draw import draw_rect_2d, draw_thick_line_3d, draw_thick_dashed_line_3d
+from ..utilities.draw import draw_rect_2d, draw_thick_line_3d, draw_thick_dashed_line_3d, WORKPLANE_LINE_SCALE
 from ..shaders import Shaders
 from ..utilities import preferences
 from ..solver import Solver
@@ -49,7 +49,7 @@ def update(self):
         rect_coords = [Vector(co) for co in rect_coords]
 
         # Use a much smaller width for workplane edges (accounting for view distance scaling)
-        line_width = 0.2
+        line_width = WORKPLANE_LINE_SCALE
 
         all_coords = []
         all_indices = []