fixed #30

Author: Ion Bazan

tests/issue_005.phpt

@@ -0,0 +1,34 @@
+--TEST--
+Check for issue #5 (DateTime reflection)
+--SKIPIF--
+<?php
+$required_version = "5.3";
+$required_func = array("timecop_freeze");
+$required_class = array("TimecopDateTime");
+include(__DIR__."/tests-skipcheck.inc.php");
+--INI--
+date.timezone=GMT
+timecop.func_override=1
+--FILE--
+<?php
+class Test
+{
+    public function setCreatedAt(DateTime $createdAt)
+    {
+        $this->createdAt = $createdAt;
+    }
+}
+
+$test = new Test();
+
+$reflection = new ReflectionClass($test);
+$params = $reflection->getMethod('setCreatedAt')->getParameters();
+
+foreach ($params as $param) {
+    var_dump($param->getClass());
+}
+--EXPECT--
+object(ReflectionClass)#3 (1) {
+  ["name"]=>
+  string(8) "DateTime"
+}

tests/issue_030.phpt

@@ -0,0 +1,33 @@
+--TEST--
+Check for issue #30 (DateTimeImmutable::createFromFormat with ! returns DateTime)
+--SKIPIF--
+<?php
+$required_version = "5.5";
+$required_func = array("timecop_freeze");
+$required_class = array("TimecopDateTimeImmutable");
+include(__DIR__."/tests-skipcheck.inc.php");
+--INI--
+date.timezone=GMT
+timecop.func_override=1
+--FILE--
+<?php
+var_dump(\DateTimeImmutable::createFromFormat('!Y-m-d', '2017-10-03'));
+var_dump(\DateTimeImmutable::createFromFormat('Y-m-d!', '2017-10-03'));
+--EXPECT--
+object(DateTimeImmutable)#1 (3) {
+  ["date"]=>
+  string(26) "2017-10-03 00:00:00.000000"
+  ["timezone_type"]=>
+  int(3)
+  ["timezone"]=>
+  string(3) "GMT"
+}
+object(DateTimeImmutable)#1 (3) {
+  ["date"]=>
+  string(26) "1970-01-01 00:00:00.000000"
+  ["timezone_type"]=>
+  int(3)
+  ["timezone"]=>
+  string(3) "GMT"
+}
+

timecop.c

@@ -1925,8 +1925,13 @@ static void _timecop_date_create_from_format(INTERNAL_FUNCTION_PARAMETERS, int i
 	INIT_ZVAL(orig_time);
 	ZVAL_STRINGL(&orig_time, orig_time_str, orig_time_len, 0);
 #endif
+	if (immutable) {
+		real_func = ORIG_FUNC_NAME("date_create_immutable_from_format");
+	} else {
+		real_func = ORIG_FUNC_NAME("date_create_from_format");
+	}
 
-	call_php_function_with_3_params(ORIG_FUNC_NAME("date_create_from_format"), &dt, &orig_format, &orig_time, orig_timezone);
+	call_php_function_with_3_params(real_func, &dt, &orig_format, &orig_time, orig_timezone);
 
 #if PHP_MAJOR_VERSION >= 7
 	if (Z_TYPE(dt) == IS_FALSE) {
@@ -2021,12 +2026,6 @@ static void _timecop_date_create_from_format(INTERNAL_FUNCTION_PARAMETERS, int i
 #else
 	call_php_function_with_3_params("sprintf", &new_time, &tmp, fixed_time, &orig_time);
 #endif
-
-	if (immutable) {
-		real_func = ORIG_FUNC_NAME("date_create_immutable_from_format");
-	} else {
-		real_func = ORIG_FUNC_NAME("date_create_from_format");
-	}
 #if PHP_MAJOR_VERSION >= 7
 	call_php_function_with_3_params(real_func, return_value, &new_format, &new_time, orig_timezone);
 #else