Skip to content

Commit da26087

Browse files
authored
Add core-test ci with Python 3.12 (#1180)
1 parent 10590ec commit da26087

File tree

4 files changed

+52
-2
lines changed

4 files changed

+52
-2
lines changed

.github/workflows/test.yaml

Lines changed: 46 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,3 +58,49 @@ jobs:
5858
run: |
5959
conda activate test-environment
6060
codecov
61+
core_test_suite:
62+
name: Core tests on Python ${{ matrix.python-version }}, ${{ matrix.os }}
63+
needs: [pre_commit]
64+
runs-on: ${{ matrix.os }}
65+
strategy:
66+
fail-fast: false
67+
matrix:
68+
os: ['ubuntu-latest']
69+
python-version: ['3.12']
70+
timeout-minutes: 120
71+
defaults:
72+
run:
73+
shell: bash -el {0}
74+
env:
75+
DESC: "Python ${{ matrix.python-version }}, ${{ matrix.os }} core tests"
76+
PYTHON_VERSION: ${{ matrix.python-version }}
77+
steps:
78+
# Add back when this works on Python 3.12
79+
# - uses: holoviz-dev/holoviz_tasks/install@v0.1a17
80+
# with:
81+
# name: core_test_suite
82+
# python-version: ${{ matrix.python-version }}
83+
# # channel-priority: strict
84+
# channels: pyviz/label/dev,conda-forge,nodefaults
85+
# envs: "-o tests_core -o tests_ci"
86+
# cache: true
87+
# conda-update: true
88+
# id: install
89+
- uses: actions/checkout@v3
90+
with:
91+
fetch-depth: "100"
92+
- name: Fetch unshallow
93+
run: git fetch --prune --tags --unshallow -f
94+
- uses: actions/setup-python@v4
95+
with:
96+
python-version: 3.12
97+
- run: |
98+
python -m pip install -ve '.[tests_core]'
99+
- name: bokeh sampledata
100+
run: |
101+
# conda activate test-environment
102+
bokeh sampledata
103+
- name: doit test_unit
104+
run: |
105+
# conda activate test-environment
106+
pytest hvplot

hvplot/tests/testoperations.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
import pytest
1212

1313
from holoviews import Store, render
14-
from holoviews.element import Image, QuadMesh, ImageStack, Points
14+
from holoviews.element import Image, QuadMesh, Points
1515
from holoviews.core.spaces import DynamicMap
1616
from holoviews.core.overlay import Overlay
1717
from holoviews.element.chart import Scatter
@@ -204,6 +204,9 @@ def test_datashade_rescale_discrete_levels_default_True(self):
204204
def test_rasterize_by(self):
205205
if Version(hv.__version__) < Version('1.18.0a1'):
206206
raise SkipTest('hv.ImageStack introduced after 1.18.0a1')
207+
208+
from holoviews.element import ImageStack
209+
207210
expected = 'category'
208211
plot = self.df.hvplot(x='x', y='y', by=expected, rasterize=True, dynamic=False)
209212
assert isinstance(plot, ImageStack)

setup.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -150,6 +150,7 @@ def get_setup_version(reponame):
150150
"Programming Language :: Python :: 3.9",
151151
"Programming Language :: Python :: 3.10",
152152
"Programming Language :: Python :: 3.11",
153+
"Programming Language :: Python :: 3.12",
153154
"Operating System :: OS Independent",
154155
"Intended Audience :: Science/Research",
155156
"Intended Audience :: Developers",

tox.ini

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
[tox]
55
# python version test group extra envs extra commands
6-
envlist = {py38,py39,py310,py311}-{simple,unit,examples,all}-{default}-{dev,pkg}
6+
envlist = {py38,py39,py310,py311,py312}-{simple,unit,examples,all}-{default}-{dev,pkg}
77

88
[_simple]
99
description = Run simple tests

0 commit comments

Comments
 (0)