-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New target picker #27284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New target picker #27284
Conversation
…ntend into target-selector
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 38 out of 39 changed files in this pull request and generated 2 comments.
| const area = mockArea({ | ||
| area_id: "area_1", | ||
| }); | ||
|
|
Copilot
AI
Oct 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test is passing an empty object {} instead of a proper floors object to getAreaContext. Based on the function signature change, this should be { floor_1: floor } to match the test expectation.
| // No floors available, so pass an empty floors object |
| const result = getAreaContext(area, { | ||
| floor_1: floor, |
Copilot
AI
Oct 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test is passing a floors object with floor_1: floor, but the area being tested has floor_id: 'floor_1', so this should work correctly. However, the first test case also needs to be fixed to pass the floors object properly.
Proposed change
TODO:
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: