Skip to content

Conversation

@wendevlin
Copy link
Member

@wendevlin wendevlin commented Oct 1, 2025

Proposed change

TODO:

  • open picker on mobile sometimes doesn't load the list

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 38 out of 39 changed files in this pull request and generated 2 comments.

const area = mockArea({
area_id: "area_1",
});

Copy link

Copilot AI Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test is passing an empty object {} instead of a proper floors object to getAreaContext. Based on the function signature change, this should be { floor_1: floor } to match the test expectation.

Suggested change
// No floors available, so pass an empty floors object

Copilot uses AI. Check for mistakes.
Comment on lines +29 to +30
const result = getAreaContext(area, {
floor_1: floor,
Copy link

Copilot AI Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test is passing a floors object with floor_1: floor, but the area being tested has floor_id: 'floor_1', so this should work correctly. However, the first test case also needs to be fixed to pass the floors object properly.

Copilot uses AI. Check for mistakes.
@wendevlin wendevlin marked this pull request as ready for review October 10, 2025 16:44
@bramkragten bramkragten merged commit 77874aa into dev Oct 14, 2025
15 checks passed
@bramkragten bramkragten deleted the target-selector branch October 14, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed hacktoberfest Noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants