fixed co-pilot findings and removed outdated todo

Author: vaterlangen

include/battery/zendure/Stats.h

@@ -170,7 +170,7 @@ class Stats : public ::Batteries::SmartBufferStats {
     }
 
     void setHwVersion(String&& version) {
-        _hwversion = _device.value_or("UNKOWN");
+        _hwversion = _device.value_or("UNKNOWN");
 
         if (!version.isEmpty()) {
             _hwversion += " (" + std::move(version) + ")";

include/solarcharger/smartbufferbatteries/Stats.h

@@ -33,7 +33,6 @@ friend class Provider;
     // no need to republish values received via mqtt
     void mqttPublishSensors(const boolean forcePublish) const final {}
 
-    // ToDo @vaterlangen: rework battery interface for pushing updates
     std::optional<uint32_t> addDevice(std::optional<String> const& manufacture, std::optional<String> const& device, std::optional<String> const& serial, const size_t numMppts);
     bool hasDevice(std::optional<const uint32_t> id);
     void setMpptPower(std::optional<const uint32_t> id, const size_t num, const float power, const uint32_t updated);

src/solarcharger/smartbufferbatteries/Stats.cpp

@@ -31,7 +31,7 @@ std::optional<float> Stats::getOutputVoltage() const
             if (!getValueIfNotOutdated(mppt->_lastUpdate, mppt->_voltage).has_value()) {
                 continue;
             }
-            minimum = min(minimum, mppt->_voltage);
+            minimum = std::min(minimum, mppt->_voltage);
         }
     }
 
@@ -163,7 +163,7 @@ std::optional<uint32_t> Stats::addDevice(std::optional<String> const& manufactur
         return std::nullopt;
     }
 
-    // calculate CRC32 of device data to generate an (almost) unique idenitfier to be used as key in the map
+    // calculate CRC32 of device data to generate an (almost) unique identifier to be used as key in the map
     const String name = *manufacture + *device + *serial + String(numMppts);
     CRC32 crc(CRC32_POLYNOME, CRC32_INITIAL, CRC32_XOR_OUT, false, false);
     crc.add(reinterpret_cast<const uint8_t*>(name.c_str()), name.length());