Since PDCinit returns a uint64_t, 0 should indicate failure (#233)

Co-authored-by: Jean Luca Bez <jlbez@lbl.gov>

Author: TheAssembler1

docs/readme.md

@@ -68,7 +68,7 @@
     - Input: 
       + pdc_name is the reference for PDC class. Recommended use "pdc"
     - Output: 
-      + PDC class ID used for future reference.
+      + PDC class ID used for future reference or 0 on failure.
     - All PDC client applications must call PDCinit before using it. This function will setup connections from clients to servers. A valid PDC server must be running.
     - For developers: currently implemented in pdc.c.
   + perr_t PDCclose(pdcid_t pdcid)

src/api/include/pdc.h

@@ -50,7 +50,7 @@ int PDC_timing_report(const char *prefix);
  *
  * \param pdc_name [IN]         Name of the PDC
  *
- * \return PDC id on success / -1 on failure
+ * \return PDC id on success / 0 on failure
  */
 pdcid_t PDCinit(const char *pdc_name);
 

src/api/pdc.c

@@ -90,22 +90,22 @@ PDCinit(const char *pdc_name)
     FUNC_ENTER(NULL);
 
     if (NULL == (pdc_id_list_g = (struct pdc_id_list *)PDC_calloc(1, sizeof(struct pdc_id_list))))
-        PGOTO_ERROR(FAIL, "PDC global id list: memory allocation failed");
+        PGOTO_ERROR(0, "PDC global id list: memory allocation failed");
 
     if (PDC_class_init() < 0)
-        PGOTO_ERROR(FAIL, "PDC class init error");
+        PGOTO_ERROR(0, "PDC class init error");
     pdcid = PDC_class_create(pdc_name);
 
     if (PDC_prop_init() < 0)
-        PGOTO_ERROR(FAIL, "PDC property init error");
+        PGOTO_ERROR(0, "PDC property init error");
     if (PDC_cont_init() < 0)
-        PGOTO_ERROR(FAIL, "PDC container init error");
+        PGOTO_ERROR(0, "PDC container init error");
     if (PDC_obj_init() < 0)
-        PGOTO_ERROR(FAIL, "PDC object init error");
+        PGOTO_ERROR(0, "PDC object init error");
     if (PDC_region_init() < 0)
-        PGOTO_ERROR(FAIL, "PDC region init error");
+        PGOTO_ERROR(0, "PDC region init error");
     if (PDC_transfer_request_init() < 0)
-        PGOTO_ERROR(FAIL, "PDC region transfer init error");
+        PGOTO_ERROR(0, "PDC region transfer init error");
 
     // PDC Client Server connection init
     PDC_Client_init();