Merge branch 'code/hygiene'

* code/hygiene:
  hygiene, make xstrndup() act sanitising
  chore, let coverity know we've done our best
  hygiene, try and check string so i'ts untainted when passed to __strdt_special()
  hygiene, check ASCII range of special

Author: hroptatyr

src/dt-io.c

@@ -71,18 +71,18 @@ serror(const char *fmt, ...)
 
 #include "strpdt-special.c"
 
-static inline __attribute__((const, pure)) size_t
-min_z(size_t z1, size_t z2)
-{
-	return z1 <= z2 ? z1 : z2;
-}
-
+/* coverity[-tainted_data_sink: arg-0] */
 dt_strpdt_special_t
 dt_io_strpdt_special(const char *str)
 {
 	const struct dt_strpdt_special_s *res;
-	size_t len = min_z(strlen(str), 16U);
+	size_t len = strlen(str) & 0xfU;
 
+	for (size_t i = 0U; i < len; i++) {
+		if (UNLIKELY((signed char)str[i] < ' ')) {
+			return STRPDT_UNK;
+		}
+	}
 	if (UNLIKELY((res = __strpdt_special(str, len)) != NULL)) {
 		return res->e;
 	}

test/clitosis.c

@@ -1,6 +1,6 @@
 /*** clitosis.c -- command-line-interface tester on shell input syntax
  *
- * Copyright (C) 2013-2020 Sebastian Freundt
+ * Copyright (C) 2013-2021 Sebastian Freundt
  *
  * Author:  Sebastian Freundt <freundt@ga-group.nl>
  *
@@ -318,6 +318,7 @@ xmemmem(const char *hay, const size_t hayz, const char *ndl, const size_t ndlz)
 	return NULL;
 }
 
+/* coverity[-tainted_data_sink: arg-0] */
 static char*
 xstrndup(const char *s, size_t z)
 {