Merge pull request #54 from htmlacademy/feature/add-new-rules

Added rules for Vanila JS

Author: kam4atka

test/vanilla/accessor-pairs.js

@@ -0,0 +1,21 @@
+const objectSample = {
+  set key(value) {
+    this.valueThisObject = value;
+  },
+  get key() {
+    return this.valueThisObject;
+  },
+};
+
+const objectSampleOther = {key: 1};
+
+Object.defineProperty(objectSampleOther, 'anythingString', {
+  set: function(value) {
+    this.valueThisObject = value;
+  },
+  get: function() {
+    return this.valueThisObject;
+  },
+});
+
+throw new Error(objectSample);

test/vanilla/arrow-parens.js

@@ -1,21 +1,23 @@
-const a = '';
-
 () => {};
 
-(a) => {return a;};
-
-(a) => a;
+(anything) => anything;
 
-(a) => {
-  return `${a} \n`;
+(anything) => {
+  anything++;
+  return anything;
 };
 
-a.then((foo) => {
-  return foo;
+(anything) => `${anything} \n`;
+
+const emptyString = '';
+
+emptyString.then((anything) => {
+  anything = `${anything}!`;
+  return anything;
 });
 
-a.then((foo) => {
-  if (foo === true) {
-    return foo;
+emptyString.then((anything) => {
+  if (typeof anything === 'string') {
+    return anything;
   }
 });

test/vanilla/camelcase.js

@@ -0,0 +1,46 @@
+const textColor = '#112C85';
+const _textColor = '#112C85';
+const textColor_ = '#112C85';
+const TEXT_COLOR = '#112C85';
+
+const objectSample ={
+  key: 'key',
+};
+
+const doSomething = () => {};
+
+const value = objectSample.key;
+const instance = {
+  value: objectSample.key,
+};
+
+objectSample.do_something();
+objectSample.doSomething();
+doSomething();
+new doSomething();
+
+const categoryItem = {
+  categoryId: '001',
+  isCategory: true,
+};
+const {categoryId: categoryExample} = categoryItem;
+
+function doSomethingFirst({isCamelCasedInnerScore}) {
+  return isCamelCasedInnerScore;
+}
+
+function doSomethingSecond({isCamelCased: isAlsoCamelCased}) {
+  return isAlsoCamelCased;
+}
+
+function doSomethingThird({isCamelCasedInnerScore = 'default value'}) {
+  return isCamelCasedInnerScore;
+}
+
+const {categoryId = 1} = categoryItem;
+
+const {isCategory: isCamelCased} = categoryItem;
+
+const {isCategory: isCamelCasedOther = true} = categoryItem;
+
+throw new Error(textColor, _textColor, textColor_, TEXT_COLOR, value, instance, categoryExample, doSomethingFirst, doSomethingSecond, doSomethingThird, isCamelCased, isCamelCasedOther, categoryId);

test/vanilla/comma-dangles.js

@@ -1,29 +1,27 @@
-const arr0 = ['a', 'b', 'c'];
-const arr1 = [
+const characters = ['a', 'b', 'c'];
+const letters = [
   'a',
   'b',
   'c',
 ];
 
-const obj0 = {q: 'q', w: 'w'};
-const obj1 = {
-  q: 'q',
-  w: 'w',
+const category = {id: 0, name: 'office'};
+const product = {
+  id: 0,
+  categoryId: 0,
+  name: 'table',
 };
 
-const func0 = (a, b) => {
-  return a + b;
-};
-const func1 = (
-  a,
-  b,
-) => {
-  return a + b;
-};
+const matchesCategory = (categoryItem, productItem) => categoryItem.id === productItem.categoryId;
+
+const includesPattern = (
+  productName,
+  pattern,
+) => (typeof productName === 'string' && productName.includes(pattern));
 
-func0(
-  obj0.a,
-  obj0.b,
+matchesCategory(
+  category,
+  product,
 );
 
-throw new Error(arr0, arr1, obj0, obj1, func0, func1);
+throw new Error(characters, letters, includesPattern);

test/vanilla/curly.js

@@ -0,0 +1,20 @@
+const isTrue = true;
+
+const doSomething = () => {};
+const doSomethingElse = () => {};
+
+let counter = 1;
+
+if (isTrue) {
+  counter++;
+}
+
+while (isTrue) {
+  doSomething(counter);
+}
+
+if (isTrue) {
+  doSomething();
+} else {
+  doSomethingElse();
+}

test/vanilla/eqeqeq.js

@@ -0,0 +1,12 @@
+const conditionLeft = 'str';
+const conditionRight = 'str';
+
+conditionLeft === conditionRight;
+conditionLeft === true;
+conditionLeft !== 1;
+conditionLeft === undefined;
+typeof undefinedVariable === 'undefined';
+'hello' !== 'world';
+0 === 0;
+true === true;
+conditionLeft === null;

test/vanilla/indent.js

@@ -1,48 +1,40 @@
-'use strict';
-
 // Continuation, aka MemberExpression
 const promise = window.Promise.resolve(true);
 promise.
-  then((data) => {
-    return data;
-  }).
-  then((truthy) => {
-    return !truthy;
-  }).
-  catch(() => {
-    return false;
-  });
+  then((data) => data).
+  then((truthy) => !truthy).
+  catch(() => false);
 
 // Function expression
-const fun = function (first, second) {
-  return first + second;
+const calculateSum = function (sum, price) {
+  return sum + price;
 };
 
 // Function declaration
-function Constructor(first, second) {
+function Constructor(name, price) {
   this.data = {
-    first: first,
-    second: second,
+    name: name,
+    price: price,
   };
 }
 
 // Calling site arguments
-const myObject = new Constructor(
+const objectSample = new Constructor(
   'Petya',
   'Vasya',
 );
-myObject.toString();
+objectSample.toString();
 
-const result = fun(
-  'one',
-  'two',
+const result = calculateSum(
+  10000,
+  1000,
 );
 result.toString();
 
 // Switch
-const a = 'a';
+const symbol = 'a';
 
-switch(a) {
+switch(symbol) {
   case 'a':
     break;
   case 'b':

test/vanilla/no-shadow.js

@@ -0,0 +1,16 @@
+const isTrue = true;
+
+const doEnything = () => {};
+
+if (isTrue) {
+  const coordinateX = 3;
+  const coordinateY = 6;
+
+  doEnything(coordinateX, coordinateY);
+}
+
+const coordinateZ = 5;
+
+function doSomething() {}
+
+throw new Error(coordinateZ, doSomething);

test/vanilla/no-useless-concat.js

@@ -0,0 +1,16 @@
+const price = 100;
+const discount = 50;
+const count = 5;
+
+const fullPrice = price - discount;
+const discountMessage = `Discount is ${price * (discount / 100)}%`;
+const fullPriceMessage = `${fullPrice}  - FULL price!`;
+const countAfterBuy = count - 1;
+const countAfterRefund = count + 1;
+
+// when the string concatenation is multiline
+const fullMessage = 'It' +
+  'will' +
+  'make you happy!';
+
+throw new Error(discountMessage, fullPriceMessage, countAfterBuy, countAfterRefund, fullMessage);

test/vanilla/no-useless-return.js

@@ -0,0 +1,42 @@
+const isTrue = true;
+
+const doSomething = () => {};
+const doSomethingElse = () => {};
+const doDefault = () => {};
+
+function getNumberFive() { return 5; }
+
+function getFunction() {
+  return () => {};
+}
+
+function doSomethingWithIf() {
+  if (isTrue) {
+    doSomething();
+    return;
+  } else {
+    doSomethingElse();
+  }
+  doDefault();
+}
+
+function doSomethingWithSwitch() {
+  switch (isTrue) {
+    case 1:
+      doSomething();
+      return;
+    default:
+      doSomethingElse();
+  }
+}
+
+function doSomethingWithArray() {
+  const numbers = [1, 2, 3];
+  for (const number of numbers) {
+    if (number === 1) {
+      return number;
+    }
+  }
+}
+
+throw new Error(getNumberFive, getFunction, doSomethingWithIf, doSomethingWithSwitch, doSomethingWithArray);